Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative imports with remote files. #96

Merged
merged 2 commits into from
Apr 19, 2017
Merged

Fix relative imports with remote files. #96

merged 2 commits into from
Apr 19, 2017

Conversation

iurisilvio
Copy link
Contributor

Fix #95

@iurisilvio iurisilvio requested a review from ngnpope March 26, 2017 22:52
@iurisilvio iurisilvio force-pushed the relative-url-imports branch from fed2713 to 383d07c Compare March 27, 2017 13:08
@ngnpope
Copy link
Member

ngnpope commented Apr 19, 2017

I made a few tweaks and clean ups to this. As far as I can tell it doesn't break anything I am doing, but I think that there might still be more to do to fix the whole local vs remote thing...

@ngnpope
Copy link
Member

ngnpope commented Apr 19, 2017

I've tested this out and believe it doesn't regress anything but helps resolve the problems in #95 and partially resolved the issue in #83. As such I am going to merge this.

@ngnpope ngnpope merged commit 19254e1 into master Apr 19, 2017
@ngnpope ngnpope deleted the relative-url-imports branch April 19, 2017 15:46
@ngnpope ngnpope mentioned this pull request Apr 19, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngnpope ngnpope Awaiting requested review from ngnpope

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iurisilvio @ngnpope