My changes testing PeppaPEG for my needs - #145
Open
mingodad wants to merge 14 commits into
Open
Conversation
…tra string copies.
…for sizes where we don't need more than 4GB of input/grammar for memory saving and performance comparison
… accept "//" and "/**/" comments and add a missing escape character for chars, all of this to facilitate migrate/convert grammars from pegjs
…/convert/ and https://www.bottlecaps.de/rr/ui to have a railroad diagram with a command like: ../cli parse -n -G ../tests/peppa.peg -e grammar abnf.peg
soasme
self-requested a review
December 15, 2021 21:32
soasme
reviewed
Dec 15, 2021
| " --debug/-d\t\toutput debug info\n" | ||
| #endif | ||
| " --json/-j\t\tjson ast output\n" | ||
| " --json2/-J\t\tjson ast output with only arrays\n" |
Owner
There was a problem hiding this comment.
--json2 is a little bit confusing and does not clearly specify the purpose of the option.
How about --format=jsonarray?
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion.
Renamed to -jsonArray
soasme
requested changes
Dec 15, 2021
|
|
||
| # ifndef P4_CALLOC | ||
| /** | ||
| * The realloc function. By default, it's `realloc`. |
Owner
There was a problem hiding this comment.
the document should be for calloc rather than realloc.
Contributor
Author
There was a problem hiding this comment.
Thank you !
It was my fault copy and paste.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm submitting this for the author evaluate if some of it is worth add to his repository