Skip to content

add streaming response support #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+17 −3
Closed

add streaming response support #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions lib/async/http/faraday/adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,23 @@ def call(env)
request = ::Protocol::HTTP::Request.new(endpoint.scheme, endpoint.authority, method, endpoint.path, nil, headers, body)

with_timeout do
response = client.call(request)

save_response(env, response.status, encoded_body(response), response.headers)
if env.stream_response?
response = env.stream_response do |&on_data|
response = client.call(request)

response.each do |chunk|
on_data.call(chunk)
end

response
end

save_response(env, response.status, nil, response.headers)
else
response = client.call(request)

save_response(env, response.status, encoded_body(response), response.headers)
end
end
end

Expand Down
Loading