[SofaGL] Start a Sofa.SofaGL Module#109
[SofaGL] Start a Sofa.SofaGL Module#109jnbrunet merged 9 commits intosofa-framework:masterfrom psomers3:master
Conversation
* Set up bindings structure for SofaGL * Added just basic draw() and initGlew() functions
|
Hey @psomers3 Thanks a lot for this PR. Not everyone take the time to bring back their patch to the community. It is very appreciated. I will try to review it on Monday. |
|
Out of curiousity, why are Sofa.GL and Sofa.Type the only modules with a "."? |
Sofa.GL and Sofa.Type are the first two modules of the "next generation" of SOFA. You can also have a look here to get an idea of the remaining modules that should be (hopefully) created in the upcoming months. |
|
Hey @psomers3 , Your PR looks good, and would be ready to be merged. Did you had something else to add here? |
|
I guess looking at it, it would be more proper to add a description for the functions to the docs file... I can do that in a little bit. |
|
All right, I'll change the status to WIP (work in progress). Simply replace this PR label to "status: to review" once you have finished adding commits. |
|
@jnbrunet I can't change the label since I'm not a contributor, but I've added my changes and think it's good to go. |
I have started the bindings for a Sofa.SofaGL module so that other visualization tools from python can be used (two examples are also added for this). I imagine I should change the naming of the file that I do this bindings in because I started by thinking I need to wrap the drawtool and realized later that I don't need to. I can change the names to whatever you all feel appropriate if this small addition is worth it.