Skip to content

Fix rightBeforeLoadingScene method overloading #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 3 commits into from
Mar 19, 2026
Merged

Fix rightBeforeLoadingScene method overloading #585

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa7e52b
Fix rightBeforeLoadingScene method overloading
alxbilger Feb 25, 2026
ea775c2
Remove virtual keyword
alxbilger Feb 27, 2026
537dc19
Merge branch 'master' into rightBeforeLoadingScene
hugtalbot Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Plugin/src/SofaPython3/PythonEnvironment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,8 +606,9 @@ void PythonEnvironment::setArguments(const std::string& filename, const std::vec
PySys_SetArgvEx( data->size(), data->getDataBuffer(), 0);
}

void PythonEnvironment::SceneLoaderListerner::rightBeforeLoadingScene()
void PythonEnvironment::SceneLoaderListerner::rightBeforeLoadingScene(SceneLoader* sceneLoader)
{
SOFA_UNUSED(sceneLoader);
// unload python modules to force importing their eventual modifications
executePython([]{ PyRun_SimpleString("SofaRuntime.unloadModules()");});
}
Expand Down
3 changes: 1 addition & 2 deletions Plugin/src/SofaPython3/PythonEnvironment.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,8 @@ class SOFAPYTHON3_API PythonEnvironment
/// to be able to react when a scene is loaded
struct SceneLoaderListerner : public SceneLoader::Listener
{
using SceneLoader::Listener::rightBeforeLoadingScene;
/// possibly unload python modules to force importing their eventual modifications
virtual void rightBeforeLoadingScene();
virtual void rightBeforeLoadingScene(SceneLoader* sceneLoader) override;
static SceneLoaderListerner* getInstance() {
static SceneLoaderListerner sceneLoaderListerner;
return &sceneLoaderListerner; }
Expand Down
Loading