Open
Conversation
Author
|
@nkeim |
Contributor
|
Hi! Thanks for this PR!! I’ve seen SPIFF before and I’m glad it could be part of trackpy.
The more “active” maintainers are also faculty, so our attention to trackpy (for non-urgent matters) is somewhat seasonal. I can’t give you a definite timeline, but obviously our activity tends to pick up in late Spring/early summer. We’ll do our best to take a look before then!
Nathan
On Feb 3, 2026, at 2:17 PM, Abel Putnoki ***@***.***> wrote:
[https://avatars.githubusercontent.com/u/29568469?s=20&v=4]putnokiabel left a comment (soft-matter/trackpy#799)<#799 (comment)>
@nkeim<https://github.com/nkeim>
Hi, I'm new here!
Is there a process for contributing to trackpy (other than just submitting a PR and waiting)?
—
Reply to this email directly, view it on GitHub<#799 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAWY23ISYEZVWVCFIDEAVKL4KDX4HAVCNFSM6AAAAACS6XKRE6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNBTGE3TKOBZGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #695. Closes #413.
Feature
Based on https://www.nature.com/articles/s41598-017-14166-6?WT.feed_name=subjects_optical-manipulation-and-tweezers#Sec9 .
Use SPIFF to remove pixel-locking bias and improve sub-pixel accuracy of located features.
In the test cases shown (see
test_spiff.py), you can see an order of magnitude better accuracy when the SPIFF correction is applied.Sample results
Verify by adding the following line in

test_spiff.pyand running the tests:2D
error before: 0.1300
error after SPIFF: 0.01998
3D
error before SPIFF: 0.2486
error after SPIFF: 0.0227
Note on documentation and further integration
I did not invest time into updating the documentation and further integrating it into the basic features yet, as I wanted to see what the maintainers think of the feature first.
Since it seems like SPIFF improves accuracy pretty much universally, I'd suggest the following (but feel free to ignore or suggest something else):
apply_spiffargument intp.locate()andtp.batch()(could be enabled or disabled by default) and have those functions apply the SPIFF correction so the user doesn't have to know or think about it necessarily.apply_spiffargument as well as the underlyingapply_spiff_correctionfunction.apply_spiff_correctionmethod for more details on this).