Skip to content

Conversation

@martenw
Copy link

@martenw martenw commented Oct 14, 2025

Fix for #343

@adamelfstrom
Copy link
Collaborator

Hi, thank you for contributing.

While this does solve the specific issue of missing parameters for StockBalance, the other endpoint added in the referenced PR, StockPoint has the same issue which also needs to be addressed.
I also don't think this is the preferred solution.

Imo, this issue should instead be addressed by adding a search parameter class like we do for all the non-warehouse endpoints. So instead of passing in several parameters to the QueryAsync function, you would pass in an instance of e.g. StockPointSearch where the parameters are defined. Since the search class would inherit from BaseSearch, the limit and offset parameters would be available by default.

@adamelfstrom
Copy link
Collaborator

Also it seems the testing account finally stopped working, so that also needs fixing first...

@martenw
Copy link
Author

martenw commented Oct 20, 2025

Agree, this is just a fix that makes the endpoint useable but it is probably not a long-term fix. I used this implementation in my project just to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants