Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@apfitzge
Copy link
Contributor

Problem

The most common usage for bench-tps is a development cluster, which has all features enabled.

Summary of Changes

Update bench-tps tests to use a bank w/ all features enabled.

Fixes #

@apfitzge apfitzge requested a review from tao-stones June 14, 2023 22:06
@apfitzge
Copy link
Contributor Author

Running into issues in #32131 because the funding transactions cannot succeed due to the data limit instruction.

Copy link
Contributor

@tao-stones tao-stones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@apfitzge apfitzge force-pushed the tests/bench-tps_bank-features branch from 8c51544 to 54a9771 Compare June 15, 2023 16:42
@apfitzge
Copy link
Contributor Author

@taozhu-chicago did a rebase to capture bd4196b (#32145) which I think should fix the CI

@apfitzge apfitzge added the automerge Merge this Pull Request automatically once CI passes label Jun 15, 2023
@mergify mergify bot merged commit 90812fa into solana-labs:master Jun 15, 2023
@apfitzge apfitzge deleted the tests/bench-tps_bank-features branch June 15, 2023 17:58
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
wen-coding pushed a commit to wen-coding/solana that referenced this pull request Aug 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

automerge Merge this Pull Request automatically once CI passes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants