fix: remove DecodeError from trait impls #79
+748
−513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #73 and continues with similar work, in the same spirit, as the PR in
solana-sdk
(anza-xyz/solana-sdk#104).The changes have been specifically targeted to the trait implementations in order to make the consumption of the crate easier.
Motivation
Unless
DecodeError
has a particular use-case that I've missed to appreciate, this satisfies the much stricter trait solver introduced in Rust1.84.0
, and helps when implementing error traits.As it stands now, the issue above is a blocker for upgrading to more recent Solana crates in aggregate, i.e. having dependencies which in turn imports other crates, where
spl-pod
is a common denominator in the dependency forest.Note
DecodeError
is still left (and used) as a dependency due to necessary for the (current)PrintProgramError
and in the macro impls, together with the unit tests. Removing it entirely, like in the PR above, requires further work with adjusting the dependency tree.This should not be breaking, rather the opposite, in allowing newer Rust compilers to interact with the crate (directly or in-directly), and not hit the error as referenced in the issue above.