fix(cli): allow keypairs to be specified for all commands#341
Open
wowinter13 wants to merge 1 commit intosolana-program:mainfrom
Open
fix(cli): allow keypairs to be specified for all commands#341wowinter13 wants to merge 1 commit intosolana-program:mainfrom
wowinter13 wants to merge 1 commit intosolana-program:mainfrom
Conversation
wowinter13
changed the title
Kingblach9999
approved these changes
Dec 16, 2025
joncinque
reviewed
Mar 2, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Thanks for your contribution! This makes sense to me, just a nit on the naming
Comment on lines
+2348
to
+2351
| Arg::with_name("keypair_path") | ||
| .long("keypair-path") | ||
| .short("k") | ||
| .value_name("PATH") |
Contributor
There was a problem hiding this comment.
nit: let's update these to be consistent with the solana CLI
Suggested change
| Arg::with_name("keypair_path") | |
| .long("keypair-path") | |
| .short("k") | |
| .value_name("PATH") | |
| Arg::with_name("keypair") | |
| .long("keypair") | |
| .short("k") | |
| .value_name("KEYPAIR") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23