GitHub CI Workflow: Bump OS and compiler versions #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwfreed
requested changes
Feb 25, 2025
dwfreed
reviewed
Feb 25, 2025
dwfreed
reviewed
Feb 25, 2025
Co-authored-by: Doug Freed <[email protected]>
dwfreed
force-pushed
the
amdj/ci-workflow-upgrade
branch
from
af62940 to
c5bd1a3
Compare
This is simply far too frail. Have configure add -Werror to the build process instead.
This triggers diagnostics in modern compilers that end up breaking the build.
A function typedef with no prototype is not supported in modern compilers with diagnostics on. Fix the typedef and the functions passed to it.
This was never actually a problem, but GCC isn't smart enough to realise that.
Also append the CI -W flags to CFLAGS rather than prepending them. Otherwise, the CI passing --enable-warnings still turns on -Wunused-value in some other manner.
aaronmdjones
force-pushed
the
amdj/ci-workflow-upgrade
branch
from
a546753 to
d67d7ac
Compare
This ensures that whatever problem is causing ./configure to be re-run will not strip the environment variable from its invocation.
dwfreed
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.