Draft: eMode draft impl (WIP) #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xripleys
reviewed
Oct 2, 2024
0xripleys
reviewed
Oct 3, 2024
0xripleys
reviewed
Oct 3, 2024
…ccount for emode - Public function to toggle emode for a given obligation
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
- Increase test coverage
0xripleys
reviewed
Oct 4, 2024
| @@ -819,6 +843,22 @@ module suilend::lending_market { | |||
| reserve::update_reserve_config<P>(reserve, config); | |||
| } | |||
|
|
|||
| public fun set_emode_for_pair<P, T>( | |||
There was a problem hiding this comment.
i think it makes sense to get the type argument for the pair reserve as well, just as a sanity check.
There was a problem hiding this comment.
Added both:
public fun set_emode_for_pair<P, Deposit, Borrow>(
_: &LendingMarketOwnerCap<P>,
lending_market: &mut LendingMarket<P>,
deposit_reserve_array_index: u64,
borrow_reserve_array_index: u64,
open_ltv_pct: u8,
close_ltv_pct: u8,
) {
assert!(lending_market.version == CURRENT_VERSION, EIncorrectVersion);
let borrow_reserve = vector::borrow_mut(&mut lending_market.reserves, borrow_reserve_array_index);
assert!(reserve::coin_type(borrow_reserve) == type_name::get<Borrow>(), EWrongType);
let deposit_reserve = vector::borrow_mut(&mut lending_market.reserves, deposit_reserve_array_index);
assert!(reserve::coin_type(deposit_reserve) == type_name::get<Deposit>(), EWrongType);
reserve::set_emode_for_pair<P>(deposit_reserve, borrow_reserve_array_index, open_ltv_pct, close_ltv_pct);
}
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 4, 2024
0xripleys
reviewed
Oct 24, 2024
0xripleys
reviewed
Oct 31, 2024
| @@ -293,6 +401,10 @@ module suilend::reserve_config { | |||
| set_open_attributed_borrow_limit_usd(&mut builder, config.open_attributed_borrow_limit_usd); | |||
| set_close_attributed_borrow_limit_usd(&mut builder, config.close_attributed_borrow_limit_usd); | |||
|
|
|||
| if (bag::contains(&config.additional_fields, EModeKey {})) { | |||
| set_emode_ltv_for_borrow(&mut builder, *bag::borrow(&config.additional_fields, EModeKey {})) | |||
There was a problem hiding this comment.
this seems wrong. set_emode_ltv_for_borrow is expecting EmodeData. but bag::borrow(&config.additional_fields, EModeKey {}) is of type VecMap?
0xripleys
reviewed
Oct 31, 2024
contracts/sources/cell.move
Outdated
| @@ -16,6 +16,10 @@ module suilend::cell { | |||
| public fun get<Element>(cell: &Cell<Element>): &Element { | |||
| option::borrow(&cell.element) | |||
| } | |||
|
|
|||
| public fun get_mut<Element>(cell: &mut Cell<Element>): &mut Element { | |||
There was a problem hiding this comment.
i don't think we need this anymore?
0xripleys
reviewed
Oct 31, 2024
| obligation::borrow<P>(obligation, reserve, clock, borrow_amount_with_fees); | ||
| obligation::borrow<P>(obligation, &mut lending_market.reserves, reserve_array_index, clock, borrow_amount_with_fees); | ||
|
|
||
| let reserve = vector::borrow_mut(&mut lending_market.reserves, reserve_array_index); |
There was a problem hiding this comment.
ah, this is to fix the borrow checker error?
0xripleys
reviewed
Oct 31, 2024
contracts/sources/obligation.move
Outdated
| assert!(vector::length(&obligation.borrows) <= 1, EEModeNotValidWithCrossMargin); | ||
| assert!(vector::length(&obligation.deposits) <= 1, EEModeNotValidWithCrossMargin); | ||
|
|
||
| if (vector::length(&obligation.deposits) == 1) { |
There was a problem hiding this comment.
i think this case is fine, right? we'd just end up using the base ltvs
There was a problem hiding this comment.
(talking about the assertion below )
0xripleys
reviewed
Oct 31, 2024
| @@ -379,6 +381,26 @@ module suilend::lending_market { | |||
| obligation::zero_out_rewards_if_looped(obligation, &mut lending_market.reserves, clock); | |||
| coin::from_balance(receive_balance, ctx) | |||
| } | |||
|
|
|||
| /// Set emode for obligation - T is the deposit coin type | |||
| public fun set_emode<P>( | |||
There was a problem hiding this comment.
we also need the ability to unset emode. maybe call this function `set_emode_flag', which also accepts a boolean which indicates whether the obligation is emode or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.