Skip to content

Add Start v1 coverage to Start v2 #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LadyBluenotes merged 9 commits into from
Jul 27, 2026
Merged

Add Start v1 coverage to Start v2 #1588

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c966ffd
Update docs for Start v2
birkskyum Jul 21, 2026
f392ce9
Merge branch 'main' into start-2.0
kodiakhq[bot] Jul 22, 2026
a6cc94e
Merge remote-tracking branch 'upstream/main' into start-2.0
birkskyum Jul 22, 2026
2d8a4d5
Remove versionLabel modification from this PR
birkskyum Jul 22, 2026
f672f68
remove create flags
birkskyum Jul 24, 2026
5e22354
Merge branch 'main' into start-2.0
kodiakhq[bot] Jul 26, 2026
6a549eb
Merge branch 'main' into start-2.0
LadyBluenotes Jul 26, 2026
71bc2cd
account for enhancements in v2 rc.1-5 releases
birkskyum Jul 26, 2026
62d7b1e
build with rc.1
birkskyum Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions osmium/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { fileURLToPath } from "node:url";

export interface OsmiumThemeConfig {
sidebar?: SidebarConfig;
versionLabels?: Record<string, string>;
reportPagePath?: string;
missingPagePath?: string;
discord?: string;
Expand Down
7 changes: 4 additions & 3 deletions osmium/src/ui/layout/version-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,10 @@ export default function VersionSelector() {
);

const getOptionLabel = (option: SolidBaseRouteOption) => {
return typeof option.meta.label === "string"
Comment thread
birkskyum marked this conversation as resolved.
? option.meta.label
: option.name;
return (
config().themeConfig?.versionLabels?.[option.name] ??
(typeof option.meta.label === "string" ? option.meta.label : option.name)
);
};

return (
Expand Down
6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@
"@kobalte/solidbase": "catalog:",
"@solidjs/meta": "^0.29.4",
"@solidjs/router": "^0.16.1",
"@solidjs/start": "https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2080",
"@solidjs/start": "2.0.0-rc.1",
"@tailwindcss/vite": "^4.3.0",
"dotenv": "^17.3.1",
"nitro": "v3.0.260429-beta",
"nitro": "^3.0.260610-beta",
"resolve": "1.22.12",
"solid-heroicons": "^3.2.4",
"solid-js": "1.9.12",
Expand All @@ -51,7 +51,7 @@
"typescript-eslint": "^8.54.0"
},
"overrides": {
"@solidjs/start": "https://pkg.pr.new/solidjs/solid-start/@solidjs/start@2080"
"@solidjs/start": "2.0.0-rc.1"
},
"engines": {
"node": ">=24",
Expand Down
Loading
Loading