Adding send to python and retrieve from python #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request contains only changes to the README.md; I guess the other changes were already merged into the main/master branch? If so, should I just look at pythonPal.H? For README.md, it says The code in this repository is based on OpenFOAM-9, however, the code is designed to work with OpenFOAM-9, OpenFOAM-v2012 and foam-extend-4.1. I suggest you update the comments to reflect this and add a comment that it is expected to work with all similar versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added methods to send/retrieve scalars and words to Python side.
Note that the pythonPalIcoFoam solver (included) tests all those methods, and they work.
Also, updated the README.md file to include the paper by Rodriguez and Cardiff.