add new datepicker to time entry picker, add am/pm support #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=========================================
Coverage 88.57% 88.57%
- Complexity 1712 1714 +2
=========================================
Files 264 264
Lines 9156 9158 +2
=========================================
+ Hits 8110 8112 +2
Misses 1046 1046 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…other element was focused before
Onatcer
commented
Jun 24, 2025
| @@ -148,6 +148,8 @@ public function update(Organization $organization, Report $report, ReportUpdateR | |||
| $report->share_secret = null; | |||
| $report->public_until = null; | |||
| } | |||
| } elseif ($report->is_public && $request->has('public_until')) { | |||
| $report->public_until = $request->getPublicUntil(); | |||
There was a problem hiding this comment.
@korridor das update von public_until hat hier davor nicht funktioniert, außer wenn gleichzeitig public geändert wurde. passt das so oder überseh ich da wasß
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.