Fix line item option condition params #6233
Merged
+92
−61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_promotions
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6233 +/- ##
=======================================
Coverage 89.44% 89.44%
=======================================
Files 973 973
Lines 20298 20298
=======================================
Hits 18156 18156
Misses 2142 2142 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
reviewed
May 13, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. Would you mind to add some specs? This should have been caught by specs in the first place.
manleyac
force-pushed
the
fix-line-item-option-condition-params
branch
from
86bdfdb to
674cbcc
Compare
mamhoff
force-pushed
the
fix-line-item-option-condition-params
branch
from
674cbcc to
25285b3
Compare
mamhoff
force-pushed
the
fix-line-item-option-condition-params
branch
2 times, most recently
from
86edf8a to
9bb6e94
Compare
This updates the product picker for the line_item_option_value form to not allow selecting multiple products per entry.
This fixes an issue where the option-value-picker was not receiving the id for the selected product. Therefore the correct option values where not available and the params where malformed.
When creating an option value condition, we only want to have option values that fit the product in question. This commit makes it such that the option value picker re-initializes when the selected product changes.
mamhoff
force-pushed
the
fix-line-item-option-condition-params
branch
from
9bb6e94 to
b0eda8b
Compare
mamhoff
added
backport-v4.5
tvdeyen
approved these changes
Nov 18, 2025
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. Tested manually. Worth a back port, since this is an actual bug in a released version
promotions/spec/system/solidus_promotions/backend/promotions_spec.rb
Outdated
Show resolved
Hide resolved
adammathys
approved these changes
Nov 19, 2025
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug being unable to create a line_item_option_value condition. Adding a line_item_option_value as a condition to a benefit will raise a TypeError due to the form submitting an array when a hash is expected.
Currently, the product-picker allows for selecting multiple products when only one product should be selected per entry. The selected product id is not passed to the option-value-picker resulting in the params being malformed and the conditions_controller raising a 500 on create.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: