Remove inverse_of from Spree::Adjustment#order
#6373
Merged
+23
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This
inverse_ofgives rise to spurious adjustments appearing in the database if there are newly built and directly marked for destruction.Since we're never calling
adjustment.orderanywhere in production code, I am pretty sure we can remove this inverse_of safely.I believe what happens is that the adjustment gets added to
order.all_adjustmentson initialization, and marking it for destruction on the shipment does not carry on to that association as it does not have theautosaveproperty.Alternatively, we could add
autosavetoorder.all_adjustments, but that could surface even weirder bugs.Found while building #6371
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: