Allow promotion conditions to work with in-memory line items, improve performance #6383
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does four things:
DistributedAmountsHandlerto not require line items IDs, so it can work with in-memory line itemspluckand rather take advantage of loaded option values.The taxon condition is likely one of our most-used conditions, so it makes sense to spend a bit of time here making sure it's not too slow.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: