Improve Devise config initializer #257
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes two issues: solidusio/solidus#3427 and #251
For the first one: we want to use the same email validator for both users and orders, to avoid validation errors when an email is being copied from a user to an order when an order is created.
For the second issue, we want to default the
Devise.secret_key
in the initializer to what Devise recommends: https://github.com/heartcombo/devise/blob/fec67f98f26fcd9a79072e4581b1bd40d0c7fa1d/lib/devise/rails/routes.rb#L498-L506Testing
We tested this by creating a new Solidus app, changing the
solidus_auth_devise
version to this branch and re-ran the install task and confirmed the Devise config initializer had our new changes.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: