Skip to content

Conversation

@sam-heilbron
Copy link

@sam-heilbron sam-heilbron commented Nov 16, 2024

Description

update some formatting in our user-facing documentation

Context

Relies on changes introduced in solo-io/solo-kit#571

  • Format of generated docs is updated
  • .proto.sk.md files have updated tiltles, so custom_resource.proto.sk.md has a title of CustomResource

Interesting decisions

Testing steps

  • no user-facing changes, so rely on CI passing

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6612

@sam-heilbron sam-heilbron marked this pull request as ready for review November 20, 2024 16:00
@sam-heilbron sam-heilbron requested a review from a team as a code owner November 20, 2024 16:00
@soloio-bulldozer soloio-bulldozer bot merged commit e2ca028 into main Nov 22, 2024
15 of 16 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the sh/update-gloo-docs-format branch November 22, 2024 01:23
yuval-k pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants