Add support for proto3 optional fields in protoc-gen-openapi #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for approval from someone in the solo-io org to start testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #28 (#28))
which highlights a lack of support for optional fields in proto3 syntax.
The issue is that proto3 optional fields are not supported. The fix adds detection of proto3 optional fields using the Proto3Optional field descriptor property and ensures they are not marked as required in the OpenAPI schema, which correctly reflects their optional nature.
Changes in MakeFile - Added a test proto file with proto3 optional fields to the protoc command to ensure the plugin can handle proto3 optional fields during testing and development