anchors in headings #584
anchors in headings #584
Conversation
Signed-off-by: Art Berger <[email protected]>
Signed-off-by: Art Berger <[email protected]>
|
Issues linked to changelog: |
| return printPointer | ||
| // For Hugo, we need to generate the same numbered anchors as toAnchorLink | ||
| // Track anchor names to handle duplicates | ||
| anchorCounts := make(map[string]int) |
There was a problem hiding this comment.
At first, this looks a bit strange but is the idea that anchorCounts is declare here because toHeading() is called only once and anchorCounts get "auto"captured into the returned function and that's the function that will get called multiple times? That's a clever hack without local static like in C++.
There was a problem hiding this comment.
yeah the toHeading is called once during the template setup, but this returned function is called for each heading instance. We needed separate anchorCounts funcs under both toHeading and toAnchorLink because they were counting different things (headings vs anchors), so to keep them in sync so the headings match the anchor counts. Before without this, it was only counting the anchors and replacing it for non-heading links 😅
followup to #583, for https://github.com/solo-io/doctopus/issues/124, more context in Slack
Tested by doing this in the
gloorepo:go get github.com/solo-io/solo-kit@adb-anchors2make generate-all -BBOT NOTES:
resolves https://github.com/solo-io/doctopus/issues/124