Skip to content

fix: lazily import soundfile in datasets - #15

Merged
anubhutivyas merged 1 commit into
nmp/customizerfrom
anubhutiv/fix-soundfile
Aug 20, 2026
Merged

fix: lazily import soundfile in datasets#15
anubhutivyas merged 1 commit into
nmp/customizerfrom
anubhutiv/fix-soundfile

Conversation

@anubhutivyas

@anubhutivyas anubhutivyas commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

What does this PR do ?

Traceback (most recent call last):
  File "/app/services/rl/src/nmp/rl/tasks/training/backends/nemo_rl/dpo_driver.py", line 21, in <module>
    from nemo_rl.algorithms.dpo import MasterConfig, dpo_train, setup
  File "/opt/nemo-rl/nemo_rl/algorithms/dpo.py", line 31, in <module>
    from nemo_rl.data.datasets import AllTaskProcessedDataset
  File "/opt/nemo-rl/nemo_rl/data/datasets/__init__.py", line 15, in <module>
    from nemo_rl.data.datasets.eval_datasets import load_eval_dataset
  File "/opt/nemo-rl/nemo_rl/data/datasets/eval_datasets/__init__.py", line 15, in <module>
    from nemo_rl.data.datasets.eval_datasets.daily_omni import DailyOmniEvalDataset
  File "/opt/nemo-rl/nemo_rl/data/datasets/eval_datasets/daily_omni.py", line 20, in <module>
    from nemo_rl.data.datasets.response_datasets.daily_omni import DailyOmniDataset
  File "/opt/nemo-rl/nemo_rl/data/datasets/response_datasets/__init__.py", line 20, in <module>
    from nemo_rl.data.datasets.response_datasets.audiomcq import AudioMCQDataset
  File "/opt/nemo-rl/nemo_rl/data/datasets/response_datasets/audiomcq.py", line 20, in <module>
    import soundfile as sf
ModuleNotFoundError: No module named 'soundfile'
  • Fix is to lazily import soundfile

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
@anubhutivyas
anubhutivyas merged commit cd42a71 into nmp/customizer Aug 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants