HLD for port FEC FLR support #1948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This document provides information about the implementation of Port Forward Error Correction (FEC) Frame Loss Ratio (FLR) support in SONiC.
|
/azp run |
|
No pipelines are associated with this pull request. |
prgeor
reviewed
Apr 2, 2025
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@vkjammala-arista can we change the title to "Predicted Frame Loss Ratio Estimation" ? |
We are introducing observed FEC FLR as well in this HLD, that's the reason i have put |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
No pipelines are associated with this pull request. |
1) Add images to help understand predicted FEC FLR better. 2) Display accuracy (R^2) information along with predicted FEC FLR value. 3) Add small note on using window from 16 to 20. Update FEC FLR formula considering interleaving factor to include MFC.
|
/azp run |
|
No pipelines are associated with this pull request. |
prgeor
reviewed
Sep 17, 2025
prgeor
reviewed
Sep 17, 2025
prgeor
reviewed
Sep 17, 2025
1) portstat CLI fields renaming, FEC_FLR --> FLR(O) and FEC_FLR_PREDICTED --> FLR(P) 2) Rename "fec-flr-interval-factor" to "flr-interval-factor" 3) CLI output explanation is updated to highlight that atleast 2 non-zero bin values is needed for predicted flr computation.
|
/azp run |
|
No pipelines are associated with this pull request. |
prgeor
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This document provides information about the implementation of Port Forward Error Correction (FEC) Frame Loss Ratio (FLR) support in SONiC.
Fixes #2068
Code PRs for tracking
The code pull requests should merge in the order they are mentioned in the table.