Add netconf docker to build-image #19492
Conversation
|
Hello @zhangyanzhao @aseaudi This is the remaining part of the NETCONF server implementation, integration in the sonic-build-image. For your info |
hussamsh
force-pushed
the
master
branch
2 times, most recently
from
bd04b1b to
26c382e
Compare
|
/azp run Azure.sonic-buildimage |
|
Pull request contains merge conflicts. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
I have already implemented all of these RPCs locally , what I am sharing today is a minimal implementation with Once NETCONF is accepted into SONiC I will update the sonic-netconf-server submodule with all of the missing RPCs. Do you think it is better to share the entire NETCONF implementation from the start ? |
|
@hussamsh Thank you for the clarification. Since the implementation resides in a separate repository, its completeness doesn’t directly affect the review of this PR. However, including the full implementation from the start could help facilitate broader discussions and a more comprehensive assessment of the overall NETCONF integration into SONiC. |
|
Hi @hussamsh, Thanks for the quick update and for looking into this! That's great to hear you'll be updating the PR to the latest sonic-netconf-server commit. This should definitely resolve the runtime panic we observed with the older version. On a related note regarding sonic-mgmt-common, I've observed that the later commits of sonic-netconf-server seem to call translib.GetYanglibInfo. This function might not be exported in the current sonic-mgmt-common master branch. So, if we move to the latest sonic-netconf-server, it looks like another PR might be needed in sonic-mgmt-common to export translib.GetYanglibInfo to ensure proper build and functionality. |
zhangyanzhao
moved this from 📋 In Plan Features
to 🏗 In Progress
in SONiC 202511 Release
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@EmmaLin11 |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 19492 in repo sonic-net/sonic-buildimage |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
5 participants
Why I did it
I wanted to add NETCONF server support for configuring SONiC switches. Similar to the work done on RESTCONF server.
How I did it
First, the changes themselves are on the
Official sonic netconf repositroy.This work focuses on integrating the netconf server in build-image processes. I updated relevant build scripts , dockerfiles and git modules to include the netconf server in the final image.
How to verify it
ssh <username>@<ip> -p 830 -s netconfDescription for the changelog
This change adds support for a RFC compliant NETCONF server for SONiC switches.
Implements sonic-net/SONiC#1466
Implements sonic-net/SONiC#1498
Uses sonic-net/sonic-netconf-server#2