[thrift] Add SHA256 verification for thrift 0.14.1 download#25711
Open
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Open
[thrift] Add SHA256 verification for thrift 0.14.1 download#25711rustiqly wants to merge 1 commit intosonic-net:masterfrom
rustiqly wants to merge 1 commit intosonic-net:masterfrom
Conversation
Add SHA256 checksum verification for the Apache Thrift 0.14.1 source tarball downloaded from archive.apache.org. Signed-off-by: Rustiqly <rustiqly@users.noreply.github.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added SHA256 checksum verification for the Apache Thrift 0.14.1 source tarball.
Why I did it
The thrift 0.14.1 tarball is downloaded from
archive.apache.orgwithout integrity verification. A compromised mirror or MITM could inject malicious code.How I did it
Added
THRIFT_SHA256constant andsha256sum -cverification after download.How to verify it
Part of a series to add SHA256 verification to all external downloads.