Issue 25728: Add vrf ordering dependency to chrony config#25729
Open
anders-nexthop wants to merge 1 commit intosonic-net:masterfrom
Open
Issue 25728: Add vrf ordering dependency to chrony config#25729anders-nexthop wants to merge 1 commit intosonic-net:masterfrom
anders-nexthop wants to merge 1 commit intosonic-net:masterfrom
Conversation
When chrony is configured to start in the mgmt vrf, it needs to be ordered after interfaces-config.service, since that's the service that sets up the mgmt vrf. NTP/chrony service is not coming up correctly after reboot/reload when configured to start in the mgmt vrf. When being run in the mgmt vrf, chrony needs to wait to start up until the mgmt vrf is created, so add an `After` dependency in the chrony config override file that waits for the appropriate service to finish (interfaces-config.service). Manually verified. Configure the device to enable the mgmt vrf and to have ntp configured to use the mgmt vrf. Then issue a reboot or 'config reload'. Without these changes, chrony will come up incorrectly and require a restart to function (this is a race condition, so the exact failure can be different, and it can even work occasionally, but fails pretty consistently). With these changes, reboot/reload work as expected. Signed-off-by: Anders Linn <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@saiarcot895 this one is a follow up to the chrony bind issue, apologies if you aren't the right person to bug about this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When chrony is configured to start in the mgmt vrf, it needs to be ordered after interfaces-config.service, since that's the service that sets up the mgmt vrf.
Closes #25728
Why I did it
NTP/chrony service is not coming up correctly after reboot/reload when configured to start in the mgmt vrf.
How I did it
When being run in the mgmt vrf, chrony needs to wait to start up until the mgmt vrf is created, so add an After dependency in the chrony config override file that waits for the appropriate service to finish (interfaces-config.service).
How to verify it
Manually verified. Configure the device to enable the mgmt vrf and to have ntp configured to use the mgmt vrf. Then issue a reboot or 'config reload'. Without these changes, chrony will come up incorrectly and require a restart to function (this is a race condition, so the exact failure can be different, and it can even work occasionally, but fails pretty consistently). With these changes, reboot/reload work as expected.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)