Patch policy update #318
Draft
Patch policy update #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patches will be moved into the folders in a later commit as part of this PR. |
paulmenzel
reviewed
May 17, 2023
|
|
||
| ## Description | ||
| This repository contains the scripts and patches to build the kernel for SONiC. SONiC uses the same kernel for all platforms. We prefer to out-of-tree kernel platform modules. We accept kernel patches on following conditions: | ||
| This repository contains the scripts and patches to build the kernel for SONiC. SONiC uses the same kernel for all amd64 platforms (armhf and arm64 platforms currently have platform-specific kernels). We accept kernel patches on following conditions: |
There was a problem hiding this comment.
I’d add one dot/period before after platforms before starting the ()., and move the dot/period at the end inside the (), as it’s a full sentence.
| - Please include the original upstream commit ID and message in the patch or the PR description. This allows the maintainer to remove upstream patches during the kernel upgrade. | ||
| - Those patches will be upstreamed or are in the process of being upstreamed. | ||
| - If being upstreamed, please include a link to the mail thread in the patch or PR description. | ||
| - Those patches don't make sense to be upstreamed, either because they're applicable only within SONiC or they would break some general use case. |
There was a problem hiding this comment.
Maybe make that a separate commit with a separate discussion. In my opinion, all code needs to be upstreamed. Maybe add, that there needs to be a convincing explanation, why code cannot be upstreamed.
saiarcot895
commented
Apr 17, 2024
lguohan
previously approved these changes
Jun 14, 2024
Patches will be moved into separate folders in a later commit. Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
force-pushed
the
readme-policy-update
branch
from
45c6386 to
42a2e97
Compare
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
paulmenzel
reviewed
Jul 31, 2024
|
Is there a clear distinction between the two? Perhaps the formatting changes done in the second half of the document as a separate PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the repo's
README.mdfile to cover the current policies for accepting kernel patches.Also update the CODEOWNERS file with the current team name, so that maintainers get notified of PRs.