Skip to content

Conversation

@vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Sep 24, 2025

What I did

  • Support FNIC pipeline changes for DashEniFwd Orch (No match on Tunnel VNI and only match on INNER_DST_MAC)
  • Update DashEniFwdOrch to handle the updated schema for DPU, VDPU, REMOTE_DPU & DASH_ENI_FORWARD_TABLE
  • Delete the ACL Table if all the ENI acl rules are deleted
  • While creating Tunnel NH, also pass VNI.
  • Update Aclorch to accept Tunnel NH in the following format: endpoint_ip@tunnel_name[,vni][,mac]
  • Simplify the logic by removing the reference counting logic for Remote NH Tunnel tracking
  • Added REQ_T_STRING_LIST option to Request parser
  • Allow Relaxed Attribute parsing to Request parser
  • Refactored macros
  • Updated UT's

NOTE: In ENI based forwarding, entire cluster shares the same VIP. Currently i defined a temporary Config DB table to consume VIP.

Why I did it

HLD update: sonic-net/SONiC#2081

Here is the latest schema:
https://github.com/sonic-net/SONiC/blob/91c3d94be67c96b2cba7fa8ce43bfff540638971/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md#2111-dpu--vdpu-definitions

https://github.com/sonic-net/SONiC/blob/91c3d94be67c96b2cba7fa8ce43bfff540638971/doc/smart-switch/high-availability/smart-switch-ha-detailed-design.md#2321-dash_eni_forward_table

How I verified it

Ran Tests

Details if related

@vivekrnv vivekrnv requested a review from prsunny as a code owner September 24, 2025 14:54
@mssonicbld
Copy link
Collaborator

/azp run

@vivekrnv vivekrnv requested review from zjswhhh and removed request for prsunny September 24, 2025 14:54
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Oct 3, 2025

@prsunny, @zjswhhh, @prabhataravind Please help review and signoff

@vivekrnv vivekrnv marked this pull request as draft October 6, 2025 16:48
@KrisNey-MSFT
Copy link

hi @vivekrnv , this is still in Draft. Do reviews normally happen when a PR is in Draft state?

@vivekrnv
Copy link
Contributor Author

vivekrnv commented Oct 8, 2025

hi @vivekrnv , this is still in Draft. Do reviews normally happen when a PR is in Draft state?

No, We recently had some design changes and i need to make further changes to this PR and so i moved it to draft

1) Always match on INNER_DST_MAC for Floating NIC
2) No need to match on Tunnel VNI

Signed-off-by: Vivek Reddy <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv vivekrnv changed the title [Dash] Update ENI Forward Orch to handle new DPU Table schema [Dash] Update ENI Based Forwarding Orchagent to suite FNIC Oct 10, 2025
@vivekrnv vivekrnv marked this pull request as ready for review October 10, 2025 20:38
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv vivekrnv requested a review from bingwang-ms as a code owner October 31, 2025 02:04
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv vivekrnv changed the title [Dash] Update ENI Based Forwarding Orchagent to suite FNIC [Dash] Update ENI Based Forwarding Orchagent Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants