[reload] stop timers on reload #4021
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dgsudharsan
approved these changes
Aug 7, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@stepanblyschak Lets have the label until Azure/sonic-utilities.msft#226 is merged. @r12f This is an issue we found in 202412 testing. Please help to prioritize |
r12f
added
Approved for msft-202412 Branch
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
thanks Sud! merged in 202412 already. |
qiluo-msft
reviewed
Oct 2, 2025
|
|
||
| # Get the list of dependencies for sonic.target to fetch timer units | ||
| for service in _get_sonic_services(): | ||
| if service.endswith('.timer'): |
There was a problem hiding this comment.
Here's one of the timers:
# /lib/systemd/system/hostcfgd.timer
[Unit]
Description=Delays hostcfgd daemon until SONiC has started
PartOf=hostcfgd.service
[Timer]
OnUnitActiveSec=0 sec
OnBootSec=1min 30 sec
Unit=hostcfgd.service
[Install]
WantedBy=timers.target sonic.target
The relation between sonic.target and the timer is only WantedBy, meaning start of sonic.target starts the timer but does not stop it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I implemented a fix to stop timers upon reload/load_minigraph. If "config reload" or "config load_minigraph" is executed soon after system has started a timer may expire in the middle of the command causing subsequent failures.
Here's what is observed:
How I did it
Stop timers associated with sonic.target
How to verify it
I put a breakpoint after stopping sonic.target. Soon after reboot I execute "config reload" command. I then wait for ~5-6 min, no services start. Without this fix, services would start.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)