Skip to content

[reload] stop timers on reload #4021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

[reload] stop timers on reload #4021

merged 2 commits into from
Oct 29, 2025

Conversation

@stepanblyschak
Copy link
Contributor

@stepanblyschak stepanblyschak commented Aug 7, 2025

What I did

I implemented a fix to stop timers upon reload/load_minigraph. If "config reload" or "config load_minigraph" is executed soon after system has started a timer may expire in the middle of the command causing subsequent failures.

Here's what is observed:

2025 Aug  6 18:29:35.532425 sonic INFO python[36429]: ansible-command Invoked with _uses_shell=True _raw_params=config load_minigraph --override_config -y warn=True stdin_add_newline=True strip_empty_ends=True argv=None chdir=None execut
able=None creates=None removes=None stdin=None
2025 Aug  6 18:29:35.754152 sonic NOTICE switch_trimming: 'load_minigraph' executing with command: config load_minigraph --override_config -y
2025 Aug  6 18:30:30.306602 sonic INFO systemd[1]: Stopped target sonic.target - SONiC services target..

2025 Aug  6 18:30:31.333507 sonic DEBUG systemd[1]: tacacs-config.timer: Timer elapsed.
2025 Aug  6 18:30:31.334003 sonic DEBUG systemd[1]: sonic.target: Installed new job sonic.target/start as 2793
2025 Aug  6 18:30:32.371292 sonic DEBUG systemd[1]: sonic.target changed dead -> active

How I did it

Stop timers associated with sonic.target

How to verify it

I put a breakpoint after stopping sonic.target. Soon after reboot I execute "config reload" command. I then wait for ~5-6 min, no services start. Without this fix, services would start.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@stepanblyschak
[reload] stop timers on reload
a44ba65 
Signed-off-by: Stepan Blyschak <[email protected]>
@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 7, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

mssonicbld commented Aug 8, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Aug 8, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Collaborator

dgsudharsan commented Aug 13, 2025

@stepanblyschak Lets have the label until Azure/sonic-utilities.msft#226 is merged. @r12f This is an issue we found in 202412 testing. Please help to prioritize

@dgsudharsan dgsudharsan mentioned this pull request Aug 13, 2025
Merged
@r12f
Copy link

r12f commented Aug 16, 2025

@stepanblyschak Lets have the label until Azure/sonic-utilities.msft#226 is merged. @r12f This is an issue we found in 202412 testing. Please help to prioritize

thanks Sud! merged in 202412 already.

@prgeor prgeor mentioned this pull request Aug 27, 2025
Open
@stepanblyschak stepanblyschak mentioned this pull request Sep 29, 2025
Merged
qiluo-msft
qiluo-msft reviewed Oct 2, 2025
View reviewed changes
@liat-grozovik
Copy link
Collaborator

liat-grozovik commented Oct 23, 2025

@qiluo-msft any concern or can we move forward the merge it?

@qiluo-msft qiluo-msft merged commit 54f6ecf into sonic-net:master Oct 29, 2025
7 checks passed
@mssonicbld
Copy link
Collaborator

mssonicbld commented Oct 29, 2025

Cherry-pick PR to msft-202412:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

+1 more reviewer

@dgsudharsan dgsudharsan dgsudharsan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Approved for msft-202412 Branch Cherry Pick Conflict_msft-202412 Created PR to msft-202412 Branch Included in msft-202412 Branch Request for msft-202412 Branch Request for msft-202506 Branch Request for 202505 Branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@stepanblyschak @mssonicbld @dgsudharsan @r12f @liat-grozovik @qiluo-msft @vivekrnv