[multi-asic] Add multi asic support for VRF and clear flowcnt-trap by DavidZagury · Pull Request #4383 · sonic-net/sonic-utilities

DavidZagury · 2026-03-22T14:50:40Z

What I did

Added multi asic support for commands:

sonic-clear flowcnt-trap {-n asic#}
config vrf -n {ASIC#} add/del {...}

How I did it

Modified the vrf and clear flowcnt-trap commands to add muti-asic support

How to verify it

Verified the commands in a multi asic device using the namespace flag

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

mssonicbld · 2026-03-22T14:50:49Z

/azp run

azure-pipelines · 2026-03-22T14:51:00Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: david.zagury <davidza@nvidia.com>

mssonicbld · 2026-03-22T20:04:02Z

/azp run

azure-pipelines · 2026-03-22T20:04:13Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-03-24T08:27:19Z

/azp run

azure-pipelines · 2026-03-24T08:27:31Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-03-24T13:53:27Z

/azp run

azure-pipelines · 2026-03-24T13:53:39Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: david.zagury <davidza@nvidia.com>

mssonicbld · 2026-03-24T14:32:24Z

/azp run

azure-pipelines · 2026-03-24T14:32:36Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2026-05-11T15:51:36Z

@DavidZagury i assume that these commands are on the command reference doc, should you update it with the updated CLI as well?

mssonicbld · 2026-05-13T10:28:34Z

/azp run

azure-pipelines · 2026-05-13T10:28:45Z

Azure Pipelines successfully started running 1 pipeline(s).

…ace support Signed-off-by: david.zagury <davidza@nvidia.com>

mssonicbld · 2026-05-13T10:56:34Z

/azp run

azure-pipelines · 2026-05-13T10:56:44Z

Azure Pipelines successfully started running 1 pipeline(s).

DavidZagury · 2026-05-13T11:16:10Z

@DavidZagury i assume that these commands are on the command reference doc, should you update it with the updated CLI as well?

Updated command reference

Copilot

Pull request overview

This PR adds multi-ASIC namespace handling to VRF configuration and trap flow counter clearing commands in sonic-utilities.

Changes:

Adds -n/--namespace support to config vrf.
Adds -n/--namespace support to sonic-clear flowcnt-trap.
Updates tests and command reference documentation for the new namespace behavior.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`config/main.py`	Adds namespace option and namespaced CONFIG_DB connection for `config vrf`.
`clear/main.py`	Passes namespace through to `flow_counters_stat` for trap flow counter clears.
`tests/vrf_test.py`	Adds VRF namespace behavior tests.
`tests/clear_test.py`	Adds `flowcnt-trap` namespace tests.
`doc/Command-Reference.md`	Documents namespace usage for VRF and flow counter clear commands.

  ```

+- Details:
+  - -n, --namespace: (Multi-ASIC) Namespace name (e.g. asic0). When omitted, the default namespace is targeted.


mssonicbld · 2026-06-02T08:11:09Z

/azp run

azure-pipelines · 2026-06-02T08:11:21Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-04T18:29:36Z

/azp run

azure-pipelines · 2026-06-04T18:29:47Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-06-04T19:13:27Z

/azp run

azure-pipelines · 2026-06-04T19:13:39Z

Azure Pipelines successfully started running 1 pipeline(s).

The `config vrf` group now treats `-n/--namespace` as optional and validates it per-subcommand: `add mgmt`/`del mgmt` reject `-n` and write to the global CONFIG_DB, while data-VRF subcommands (`add Vrf-*`, `del Vrf-*`, `add_vrf_vni_map`, `del_vrf_vni_map`) require `-n` on multi-ASIC platforms. Doc updated to match. Multi-ASIC vrf tests now use context-manager patches with the module reload inside a try/finally so the patched multi-ASIC state can't leak into later tests. Signed-off-by: david.zagury <davidza@nvidia.com>

mssonicbld · 2026-06-04T19:16:24Z

/azp run

azure-pipelines · 2026-06-04T19:16:36Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: david.zagury <davidza@nvidia.com>

mssonicbld · 2026-06-04T20:00:50Z

/azp run

azure-pipelines · 2026-06-04T20:01:00Z

Azure Pipelines successfully started running 1 pipeline(s).

Sourabh-Kumar7 · 2026-06-09T19:40:05Z

@qiluo-msft could you please help review and approve the change?

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

+    @patch('clear.main.run_command')
+    @patch('utilities_common.multi_asic.multi_asic_ns_choices', MagicMock(return_value=['']))


+    @patch('clear.main.run_command')
+    @patch('utilities_common.multi_asic.multi_asic_ns_choices',
+           MagicMock(return_value=['asic0', 'asic1', 'asic2', 'asic3']))
+    @patch.object(click.Choice, 'convert', MagicMock(return_value='asic0'))


+@click.option('--namespace', '-n', 'namespace', default=None,
+              type=click.Choice(multi_asic_util.multi_asic_ns_choices()),
+              show_default=True, help='Namespace name')


Sourabh-Kumar7 · 2026-06-09T21:20:46Z

@saiarcot895 could you please review the change?

[multi-asic] Add multi asic support for VRF and clear flowcnt-trap

9852e41

Signed-off-by: david.zagury <davidza@nvidia.com>

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from 91eaf2b to 9852e41 Compare March 22, 2026 20:03

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from 86a62ef to d754747 Compare March 24, 2026 13:53

[multi-asic] Add another test

14dc447

Signed-off-by: david.zagury <davidza@nvidia.com>

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from d754747 to 14dc447 Compare March 24, 2026 14:32

DavidZagury requested a review from oleksandrivantsiv March 30, 2026 06:47

oleksandrivantsiv previously approved these changes May 5, 2026

View reviewed changes

DavidZagury dismissed oleksandrivantsiv’s stale review via 7c4ae2f May 13, 2026 10:28

[multi-asic] Update Command-Reference for VRF and flowcnt-trap namesp…

61c00b0

…ace support Signed-off-by: david.zagury <davidza@nvidia.com>

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from 7c4ae2f to 61c00b0 Compare May 13, 2026 10:56

DavidZagury requested a review from oleksandrivantsiv May 13, 2026 11:15

oleksandrivantsiv previously approved these changes May 18, 2026

View reviewed changes

Sourabh-Kumar7 requested a review from Copilot May 30, 2026 07:16

Copilot started reviewing on behalf of Sourabh-Kumar7 May 30, 2026 07:17 View session

Copilot AI reviewed May 30, 2026

View reviewed changes

DavidZagury dismissed oleksandrivantsiv’s stale review via bd11708 June 2, 2026 08:11

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from bd11708 to 174e371 Compare June 4, 2026 18:29

DavidZagury added the Request for 202605 Branch label Jun 4, 2026

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from 174e371 to 3339459 Compare June 4, 2026 19:13

DavidZagury force-pushed the master_multi_asic_flow_vrf branch from 3339459 to 2875a23 Compare June 4, 2026 19:16

[multi-asic] Add coverage tests for VRF namespace guard branches

2d3a157

Signed-off-by: david.zagury <davidza@nvidia.com>

oleksandrivantsiv approved these changes Jun 4, 2026

View reviewed changes

Sourabh-Kumar7 requested review from Copilot and saiarcot895 June 9, 2026 19:39

Copilot started reviewing on behalf of Sourabh-Kumar7 June 9, 2026 19:39 View session

Sourabh-Kumar7 requested a review from qiluo-msft June 9, 2026 19:39

Copilot AI reviewed Jun 9, 2026

View reviewed changes

		@patch('clear.main.run_command')
		@patch('utilities_common.multi_asic.multi_asic_ns_choices', MagicMock(return_value=['']))

Conversation

DavidZagury commented Mar 22, 2026

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Mar 22, 2026

Uh oh!

azure-pipelines Bot commented Mar 22, 2026

Uh oh!

mssonicbld commented Mar 22, 2026

Uh oh!

azure-pipelines Bot commented Mar 22, 2026

Uh oh!

mssonicbld commented Mar 24, 2026

Uh oh!

azure-pipelines Bot commented Mar 24, 2026

Uh oh!

mssonicbld commented Mar 24, 2026

Uh oh!

azure-pipelines Bot commented Mar 24, 2026

Uh oh!

mssonicbld commented Mar 24, 2026

Uh oh!

azure-pipelines Bot commented Mar 24, 2026

Uh oh!

liat-grozovik commented May 11, 2026

Uh oh!

mssonicbld commented May 13, 2026

Uh oh!

azure-pipelines Bot commented May 13, 2026

Uh oh!

mssonicbld commented May 13, 2026

Uh oh!

azure-pipelines Bot commented May 13, 2026

Uh oh!

DavidZagury commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mssonicbld commented Jun 2, 2026

Uh oh!

azure-pipelines Bot commented Jun 2, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

mssonicbld commented Jun 4, 2026

Uh oh!

azure-pipelines Bot commented Jun 4, 2026

Uh oh!

Sourabh-Kumar7 commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Sourabh-Kumar7 commented Jun 9, 2026

Uh oh!