[action] [PR:66] Use shutil.move instead of os.rename to move config_db.json on place#76
Merged
mssonicbld merged 1 commit intosonic-net:202511from Apr 15, 2026
Merged
Conversation
…place **What I did** I replaced `os.rename` call with `shutil.move`. Also, I reordered imports to be in alphabetical order (cosmetic change). **Why I did it** After sonic-net/sonic-buildimage#20640, SONiC systems mount `/tmp` as separate _tmpfs_ mount. SONiC ZTP scripts currently prepares `config_dl.json` file in `/tmp` folder and then tries to **rename** file to `/etc/sonic/config_db.json`. Earlier there was no issue with that, as `/tmp` and `/etc/sonic` was residing on the same mount, on the same device. Now (`sonic-buildimage` master, and `202505` branch - sonic-net/sonic-buildimage@fbd9252), `os.rename` raises a `OSError: [Errno 18] Invalid cross-device link: '/tmp/config_dl.json' -> '/etc/sonic/config_db.json'` exception. Such behaviour of `os.rename` is [documented](https://docs.python.org/3/library/os.html#os.rename): > The operation may fail on some Unix flavors if _src_ and _dst_ are on different filesystems. I replaced `os.rename` call with `shutil.move` ([docs](https://docs.python.org/3/library/shutil.html#shutil.move)) one, which should either use `os.rename` if such operation is possible, or fall back into "manual" course of actions: first copy the file onto new place, then remove the source file. I suspect this change will also solve sonic-net#54, but I'm not entirely sure that the cause was the similar one there. Signed-off-by: Sonic Build Admin <[email protected]>
Author
|
Original PR: #66 |
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I replaced
os.renamecall withshutil.move.Also, I reordered imports to be in alphabetical order (cosmetic change).
Why I did it
After sonic-net/sonic-buildimage#20640, SONiC systems mount
/tmpas separate tmpfs mount.SONiC ZTP scripts currently prepares
config_dl.jsonfile in/tmpfolder and then tries to rename file to/etc/sonic/config_db.json. Earlier there was no issue with that, as/tmpand/etc/sonicwas residing on the same mount, on the same device. Now (sonic-buildimagemaster, and202505branch - sonic-net/sonic-buildimage@fbd9252),os.renameraises aOSError: [Errno 18] Invalid cross-device link: '/tmp/config_dl.json' -> '/etc/sonic/config_db.json'exception.Such behaviour of
os.renameis documented:I replaced
os.renamecall withshutil.move(docs) one, which should either useos.renameif such operation is possible, or fall back into "manual" course of actions: first copy the file onto new place, then remove the source file.I suspect this change will also solve #54, but I'm not entirely sure that the cause was the similar one there.
Signed-off-by: Sonic Build Admin [email protected]