-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filters #1
base: main
Are you sure you want to change the base?
add filters #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the pull request! The new features look promising. However, I’d like to ensure that the tool remains generic enough to handle any type of loglines.
Please verify that this change works correctly with the command node test/simulate.js | node index.js. Some logs from there don’t render correctly with the current modifications. Also, don’t forget to add it to the package.json if it’s missing. Feel free to add additional test cases as needed.
To expedite the process, let’s break this down into individual pull requests:
- Color change based on the logline prefix
- Filters based on Prefix (this might be tricky to generalize)
- Time filter
Thank you for your contribution! 🙌
Hey, so it works well with the given example, but parsing the logs with a regex check may introduce new set of bugs when people run this against wide variety of loglines. I like the filtering and showing logs in different colors, but I don't think we should enforce the parsing logic as a default parsing logic. I'll make some tweaks over next weekend on the parsing configuration, and then may be this PR can utilise the output from that to do filtering and colouring. thoughts? |
Sounds good to me. |
More ChatGPT...