Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filters #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add filters #1

wants to merge 4 commits into from

Conversation

TheSynt4x
Copy link

More ChatGPT...

Copy link
Owner

@soorajshankar soorajshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the pull request! The new features look promising. However, I’d like to ensure that the tool remains generic enough to handle any type of loglines.

Please verify that this change works correctly with the command node test/simulate.js | node index.js. Some logs from there don’t render correctly with the current modifications. Also, don’t forget to add it to the package.json if it’s missing. Feel free to add additional test cases as needed.

To expedite the process, let’s break this down into individual pull requests:

  1. Color change based on the logline prefix
  2. Filters based on Prefix (this might be tricky to generalize)
  3. Time filter

Thank you for your contribution! 🙌

public/app.jsx Outdated Show resolved Hide resolved
public/app.jsx Show resolved Hide resolved
public/app.jsx Outdated Show resolved Hide resolved
public/app.jsx Outdated Show resolved Hide resolved
@soorajshankar
Copy link
Owner

Hey, so it works well with the given example, but parsing the logs with a regex check may introduce new set of bugs when people run this against wide variety of loglines.

I like the filtering and showing logs in different colors, but I don't think we should enforce the parsing logic as a default parsing logic. I'll make some tweaks over next weekend on the parsing configuration, and then may be this PR can utilise the output from that to do filtering and colouring. thoughts?

@TheSynt4x
Copy link
Author

Hey, so it works well with the given example, but parsing the logs with a regex check may introduce new set of bugs when people run this against wide variety of loglines.

I like the filtering and showing logs in different colors, but I don't think we should enforce the parsing logic as a default parsing logic. I'll make some tweaks over next weekend on the parsing configuration, and then may be this PR can utilise the output from that to do filtering and colouring. thoughts?

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants