[Feat] #676 앱잼탬프 미션 목록 조회 API 파라미터 변경 #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 기존에 teamNumber 파라미터가 없는 경우 단순 전체 미션 목록 조회를 반환하는 형태였던걸 teamNumber 파라미터가 없는 경우 요청한 유저의 미션 목록 조회를 반환하도록 변경
hyerinhwang-sailin
approved these changes
Jan 4, 2026
Collaborator
hyerinhwang-sailin
left a comment
hyerinhwang-sailin
left a comment
There was a problem hiding this comment.
LGTM! 빠른 작업 감사합니다👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
앱잼탬프 미션 목록 조회 API 파라미터 변경
기존에 teamNumber 파라미터가 null 일 경우 앱잼 미참여 유저를 위한 응답값을 내려주던 방식을 teamNumber 파라미터가 null 일 경우 요청한 유저에 따른 응답값을 내려주도록 변경
기존에 service 단 메서드에서 분기 처리를 진행하던 부분을 service 단 내부로 옮겨서 분기 처리가 늘어갈 경우에 좀 더 편하게 대응할 수 있도록 함. 이 과정에서 부득이하게 boolean 같은 primitive 타입을 포기하고 TeamNumber 나 Boolean이 service 단까지 null 일 수 있음이 전파됨
To Reviewers 📢