-
Notifications
You must be signed in to change notification settings - Fork 1
[Feat] 애스크 대상 상단 고정 유저 리스트 조회 API #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
src/main/java/org/sopt/makers/internal/member/constants/AskMemberId.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package org.sopt.makers.internal.member.constants; | ||
|
|
||
| import java.util.List; | ||
| import java.util.Map; | ||
| import lombok.Getter; | ||
| import org.sopt.makers.internal.member.domain.enums.Part; | ||
|
|
||
| public class AskMemberId { | ||
| @Getter | ||
| private static final Map<Part, List<Long>> askMembersByPart = Map.of( | ||
| Part.SERVER, List.of(929L,209L), | ||
| Part.IOS, List.of(192L), | ||
| Part.ANDROID, List.of(223L), | ||
| Part.WEB, List.of(945L), | ||
| Part.DESIGN, List.of(930L), | ||
| Part.PLAN, List.of(229L) | ||
| ); | ||
|
|
||
| public static List<Long> getAskMembersByPart(Part part) { | ||
| return askMembersByPart.getOrDefault(part, List.of()); | ||
| } | ||
|
|
||
| public static List<Long> getAllAskMembers() { | ||
| return askMembersByPart.values().stream() | ||
| .flatMap(List::stream) | ||
| .toList(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,7 +15,7 @@ | |
| import java.io.Serializable; | ||
|
|
||
| @Getter | ||
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 해당 코드 변경의 이유가 있을까요?
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 이 부분 관련해서, 조회 시에 API 오류가 나서 수정하였습니다! |
||
| @NoArgsConstructor | ||
| @AllArgsConstructor(access = AccessLevel.PRIVATE) | ||
| @Builder | ||
| public class WorkPreference implements Serializable { | ||
|
|
||
49 changes: 49 additions & 0 deletions
49
src/main/java/org/sopt/makers/internal/member/dto/response/AskMemberResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| package org.sopt.makers.internal.member.dto.response; | ||
|
|
||
| import io.swagger.v3.oas.annotations.media.Schema; | ||
| import java.util.List; | ||
|
|
||
| @Schema(description = "질문 대상 멤버 응답 DTO") | ||
| public record | ||
| AskMemberResponse( | ||
| @Schema(description = "질문 대상 멤버 목록") | ||
| List<QuestionTargetMember> members | ||
| ) { | ||
| @Schema(description = "질문 대상 멤버 정보") | ||
| public record QuestionTargetMember( | ||
| @Schema(description = "멤버 ID", required = true) | ||
| Long id, | ||
|
|
||
| @Schema(description = "멤버 이름", required = true) | ||
| String name, | ||
|
|
||
| @Schema(description = "프로필 이미지 URL") | ||
| String profileImage, | ||
|
|
||
| @Schema(description = "소개") | ||
| String introduction, | ||
|
|
||
| @Schema(description = "최근 활동 정보", required = true) | ||
| MemberSoptActivityResponse latestActivity, | ||
|
|
||
| @Schema(description = "현재 커리어") | ||
| MemberCareerResponse currentCareer, | ||
|
|
||
| @Schema(description = "직전 커리어") | ||
| MemberCareerResponse previousCareer, | ||
|
|
||
| @Schema(description = "답변 보장 여부", example = "true", required = true) | ||
| Boolean isAnswerGuaranteed | ||
| ) {} | ||
|
|
||
| public record MemberSoptActivityResponse( | ||
| Integer generation, | ||
| String part, | ||
| String team | ||
| ) {} | ||
|
|
||
| public record MemberCareerResponse( | ||
| String companyName, | ||
| String title | ||
| ) {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DEV기준 유저 아이디로 되어 있는 것 같은데 혹시 PROD환경에는 코드가 어떻게 올라가나요?
PROD환경의 유저 아이디가 데브에 없는 경우가 많아서 데브 서버에 추후 에러가 날 수도 있을 것 같습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dev 에서 테스트 후, 명단 확정되면 프로덕션 배포할 때 반영할 예정입니다!