chore(ci): harden CI + roadmap for fearless-utils hygiene #1297
+3,796
−729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on, ci: make private pod auth optional; bump FearlessKeys to 0.1.5
…_install; reset FearlessKeys to 0.1.4
…decov at last known config Signed-off-by: William Richter <[email protected]>
Signed-off-by: William Richter <[email protected]>
…rom compile sources Signed-off-by: William Richter <[email protected]>
…load from compile sources Signed-off-by: William Richter <[email protected]>
…arlessKeys text exclusion Signed-off-by: William Richter <[email protected]>
…lla header during CI to fix modulemap on Xcode 18.x
…less'); pin shared-features-spm to 2b13aea
…lude; pin shared-features-spm to 2b13aea
…er in include; pin shared-features-spm to 2b13aea
…der; pin shared-features-spm
…rent; keep modulemap patch; pin shared-features-spm
… umbrella/header patches
…t token requirement during archive
…arless-utils hygiene
…o match previous CI setup
Signed-off-by: William Richter <[email protected]>
…o next pod install
Signed-off-by: William Richter <[email protected]>
…r Core Data models to avoid duplicate symbols with SSFAssetManagmentStorage Signed-off-by: William Richter <[email protected]>
…ties to satisfy references without duplicate codegen Signed-off-by: William Richter <[email protected]>
Signed-off-by: William Richter <[email protected]>
…PriceLocalStorageSubscriber for CD* entities Signed-off-by: William Richter <[email protected]>
…Factory for CD* entities (CDChainStorageItem, CDAccountInfo, CDStashItem) Signed-off-by: William Richter <[email protected]>
…d NetworkInfoViewFactory for CD* entities Signed-off-by: William Richter <[email protected]>
…kaswap settings - Import SSFAssetManagmentStorage where needed - Use concrete NSManagedObject classes from storage module - Type observable predicate to access identifier Unblocks compile errors in staking and substrate data provider. Signed-off-by: William Richter <[email protected]>
- Use module-qualified Core Data entities (CDPolkaswapRemoteSettings, CDPolkaswapDex) - Update #keyPath to module-qualified type Aligns mapper generics with repository U type and fixes compile. Signed-off-by: William Richter <[email protected]>
Use SSFAssetManagmentStorage.CDPriceData for mapper generics and methods so compilation doesn’t rely on alias visibility. Signed-off-by: William Richter <[email protected]>
- Update extension to target storage module’s CDContact - Add typealias in CoreDataAliases for CDContact Signed-off-by: William Richter <[email protected]>
Use project typealias to maintain compatibility; external module does not expose that symbol directly. Signed-off-by: William Richter <[email protected]>
Change extension to so generic repository helpers see the conformance when U is module-qualified. Signed-off-by: William Richter <[email protected]>
Import storage module and use module-qualified Core Data entities in generics. Signed-off-by: William Richter <[email protected]>
Use NSManagedObject with KVC to avoid direct dependency on generated entity class, resolving scope issues while preserving mapping behavior. Signed-off-by: William Richter <[email protected]>
Import SSFAssetManagmentStorage and target extension to its CDContactItem so CoreDataCodable conformance resolves. Signed-off-by: William Richter <[email protected]>
- Qualify CDRuntimeMetadataItem, CDPhishingItem, CDChain/CDChainNode usages - Update mappers to reference module-qualified CDPriceData and CDChainNode - Adjust GitHubPhishingAPIService and ChainRegistryFactory generics This aligns generics/conformances with SSFAssetManagmentStorage classes to resolve scope errors. Signed-off-by: William Richter <[email protected]>
…PriceData helpers - Delete local CoreDataCodable extension for CDRuntimeMetadataItem (provided by storage module) - Use alias in mappers to avoid module symbol mismatch Signed-off-by: William Richter <[email protected]>
Purge PBXBuildFile, PBXFileReference, group child, and build phase entries for deleted CDRuntimeMetadataItem+CoreDataCodable.swift to satisfy build. Signed-off-by: William Richter <[email protected]>
Remove stray comment line from Sources build phase list to satisfy xcodeproj parser. Signed-off-by: William Richter <[email protected]>
- Remove hard references to CDPriceData and priceData property - Use KVC and relationship introspection to read/write when present Signed-off-by: William Richter <[email protected]>
- Use KVC and relationship checks for priceData - Avoid compile-time references to missing Core Data classes Signed-off-by: William Richter <[email protected]>
Import SSFAssetManagmentStorage and use module-qualified CDContact in mapper and repository generics. Signed-off-by: William Richter <[email protected]>
Import SSFAssetManagmentStorage and point #keyPath to its CDChain.addressPrefix Signed-off-by: William Richter <[email protected]>
- Import SSFAssetManagmentStorage - Point all #keyPath references to module-qualified Core Data classes Signed-off-by: William Richter <[email protected]>
- Convert Decimal/NSDecimalNumber to String using NSDecimalNumber.stringValue - Update AssetModelMapper, ChainModelMapper, PriceDataMapper accordingly Signed-off-by: William Richter <[email protected]>
Use literal "version" for entityIdentifierFieldName to sidestep key-path constraint with module types. Signed-off-by: William Richter <[email protected]>
Import SSFAssetManagmentStorage and use module-qualified Core Data entity type Signed-off-by: William Richter <[email protected]>
…, pricing API) - Avoid setting/reading pricingApiType/pricingApiUrl - Pass nil for paraId/identityChain and avoid setting them in populate Signed-off-by: William Richter <[email protected]>
Use literal key "addressPrefix" for NSSortDescriptor to sidestep key-path restriction on module-qualified Core Data types. Signed-off-by: William Richter <[email protected]>
Import SSFAssetManagmentStorage and use module-qualified type in async repository generic. Signed-off-by: William Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: references:
- shared-features-spm pin 6d6cb16
- web3-swift dedupe 7.7.7
- optional Google keys injection
- FearlessKeys gated by INCLUDE_FEARLESS_KEYS