-
Notifications
You must be signed in to change notification settings - Fork 33
chore(ci): harden CI + roadmap for fearless-utils hygiene #1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
WRRicht3r
wants to merge
398
commits into
develop
Choose a base branch
from
chore/ci-utils-roadmap-hardening
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hainAccountViewModelFactory; hide Buy button by default Signed-off-by: William Richter <[email protected]>
…ested sorted calls in ChainAssetsFetching Signed-off-by: William Richter <[email protected]>
…rom LiquidityPools; rely on Common/Compatibility definitions so NetworkWorker extension resolves Signed-off-by: William Richter <[email protected]>
…AppRuntimeCoderFactory (conforms to RuntimeCoderFactoryProtocol) and using snapshot to build encoder/decoder Signed-off-by: William Richter <[email protected]>
…r AccountStatistics subscribers Signed-off-by: William Richter <[email protected]>
…m AccountStatisticsResponse directly; remove CachedNetwork* types dependency and .onAll usage Signed-off-by: William Richter <[email protected]>
…quidRewardOperationFactory can see GraphQLResponse Signed-off-by: William Richter <[email protected]>
…reward calculator and related services - SoraRewardCalculatorService.fetchQuotes: treat currencyId as String - Update ExistentialDeposit and SubstrateAccountInfoFetching to use non-optional currencyId Signed-off-by: William Richter <[email protected]>
…roperties.stacking presence in asset selection filters Signed-off-by: William Richter <[email protected]>
…timeout) and drop obsolete cacheKey override to match SSFNetwork API Signed-off-by: William Richter <[email protected]>
… via default and handle only supported types (subquery, subsquid-based) Signed-off-by: William Richter <[email protected]>
…gmentStorage import in MetaAccountMapper so CDAssetVisibility and relationships resolve Signed-off-by: William Richter <[email protected]>
- Use SSFChainRegistry.ChainSyncService concrete type in ChainSyncService - Update WebSocketEngine usage to new initializer (single URL, reconnection built-in) - Remove ConnectionStrategyImpl and WebSocketEngineError references Signed-off-by: William Richter <[email protected]>
…count/CD* classes used by MetaAccountMapper and repositories Signed-off-by: William Richter <[email protected]>
…rget Sources so CoreData mappers see PriceData as Identifiable Signed-off-by: William Richter <[email protected]>
…earless/Common/Compatibility and use group-relative sourceTree Signed-off-by: William Richter <[email protected]>
…akingAssetSettings to select chains with staking support Signed-off-by: William Richter <[email protected]>
…hecking hasFilters in WalletTransactionHistoryPresenter Signed-off-by: William Richter <[email protected]>
…ervice and fetch chains via SSFNetwork; adjust factory and coordinator fix(eth): remove fallback EthereumNodesApiKeys stubs to avoid redeclaration with CIKeys.generated.swift Signed-off-by: William Richter <[email protected]>
…setup() for protocol-typed providers to match SSFRuntimeCodingService protocol Signed-off-by: William Richter <[email protected]>
…roller accountId in StakingRebondSetupInteractor Signed-off-by: William Richter <[email protected]>
…ta; pass Data values directly for bytes32 parameters under Swift 6 Signed-off-by: William Richter <[email protected]>
… to expose ChainModel.addressPrefix and other compatibility APIs Signed-off-by: William Richter <[email protected]>
…ses using KVC and entity names; add ModelsCompatibility.swift to target to expose ChainModel.addressPrefix Signed-off-by: William Richter <[email protected]>
…less/Common/Compatibility and use group-relative sourceTree Signed-off-by: William Richter <[email protected]>
…move timeout arg) Signed-off-by: William Richter <[email protected]>
…hain.tokens.tokens ?? []) in LiquidityPoolSupplyPresenter Signed-off-by: William Richter <[email protected]>
…hain.tokens.tokens ?? []) in supply confirm and remove presenters Signed-off-by: William Richter <[email protected]>
… in details view model factory fix(staking-rewards): handle unsupported explorers via default instead of removed enum cases Signed-off-by: William Richter <[email protected]>
…tem.tokens.tokens ?? []) in AssetSelectionPresenter Signed-off-by: William Richter <[email protected]>
…strap; fix Data.bytes drift before archive Signed-off-by: William Richter <[email protected]>
…o fix 'scheme not configured for test' Signed-off-by: William Richter <[email protected]>
…shared-features before compile Signed-off-by: William Richter <[email protected]>
…ferService files (whitespace tolerant + broad fallbacks) Signed-off-by: William Richter <[email protected]>
b696313 to
45c9c3d
Compare
Signed-off-by: CI Trigger <[email protected]>
- Add Jenkins bootstrap stage to run scripts/ci/bootstrap.sh before pipeline - Harden scripts/spm-shared-features-fixes.sh to patch Data.bytes across DerivedData - Add verification logs to confirm replacements applied Fixes CI archive failure: Data.bytes not found in WalletConnect/EthereumTransfer assemblies Signed-off-by: Fearless CI Agent <[email protected]> Signed-off-by: William Richter <[email protected]>
- Use scheme fearless.tests instead of fearless - Run scripts/ci/bootstrap.sh before build/test - Target iPhone 15 latest simulator for stability Signed-off-by: William Richter <[email protected]>
- Disable private pod when GH_READ_TOKEN is absent in GitHub Actions or Jenkins PRs - Use provided GH token (GH_PAT_READ or GH_READ_TOKEN) to rewrite GitHub URLs - Keeps Jenkins behavior; extends to GH Actions for parity Signed-off-by: William Richter <[email protected]>
9c91aeb to
b7a28f0
Compare
- Use iPhone 16 (OS=latest) for tests - Fallback to generic iOS Simulator if unavailable Signed-off-by: William Richter <[email protected]>
- Broaden AddressFactory enum->struct patch across shared-features checkouts and DerivedData - Add logging for patched files - Select a concrete simulator UDID (prefer iPhone 16; fallback to first iPhone) Signed-off-by: William Richter <[email protected]>
- Fix grep pattern to detect enum AddressFactory with ERE - Run spm-shared-features-fixes.sh just before xcodebuild in GH Actions Signed-off-by: William Richter <[email protected]>
- Use -clonedSourcePackagesDirPath to a stable workspace path - Run shared-features patch after resolve and reuse SP_DIR for tests build Signed-off-by: William Richter <[email protected]>
- Apply sed across all swift sources in shared-features-spm checkout - Keeps previous targeted conversion and instance extension Signed-off-by: William Richter <[email protected]>
- Set http.lowSpeedLimit=0 and lowSpeedTime high - Increase http.postBuffer - Disable aggressive GC during checkout Signed-off-by: William Richter <[email protected]>
- Normalize addressFactory usage to AddressFactory.Type in SSFPolkaswap - Add preflight to fail if enum AddressFactory remains after patch Signed-off-by: William Richter <[email protected]>
- Handle module-qualified AddressFactory and var/let patterns - Print remaining addressFactory annotations for diagnostics Signed-off-by: William Richter <[email protected]>
- Fallback to grep if rg missing - Target replacements for RemotePolkaswapPoolsService/PolkaswapOperationFactory Signed-off-by: William Richter <[email protected]>
- chmod -R u+w on SPM Sources before edits - Target init/addressFactory patterns and avoid accidental renames Signed-off-by: William Richter <[email protected]>
- Continue build; rely on SSFPolkaswap type-token patch to avoid uninhabited errors Signed-off-by: William Richter <[email protected]>
- Use -E and remove � for BSD sed compatibility - Add explicit patch for SSFUtils/AddressFactory.swift Signed-off-by: William Richter <[email protected]>
- Replace boundary � with explicit char class endings - Add fallback direct replacements on targeted files Signed-off-by: William Richter <[email protected]>
- In targeted SSFPolkaswap files, rewrite self.addressFactory = addressFactory to type(of:) to satisfy .Type Signed-off-by: William Richter <[email protected]>
…already metatype - Replace self.addressFactory = type(of: addressFactory) back to direct assignment in targeted files Signed-off-by: William Richter <[email protected]>
- If param is AddressFactory.Type, keep direct assignment - Else assign metatype with type(of:) Signed-off-by: William Richter <[email protected]>
- Normalize property to AddressFactory.Type (dedupe .Type.Type) - Replace self.addressFactory = addressFactory with AddressFactory.self Signed-off-by: William Richter <[email protected]>
…essFactory.self - Line-anchored and inline pattern to catch spacing/comments variants in targeted files Signed-off-by: William Richter <[email protected]>
…den assignment rewrite - Collapse any AddressFactory.Type.Type -> AddressFactory.Type - Aggressive replacement of self.addressFactory = addressFactory (spacing/comments) to AddressFactory.self Signed-off-by: William Richter <[email protected]>
…et files Signed-off-by: William Richter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: references:
- shared-features-spm pin 6d6cb16
- web3-swift dedupe 7.7.7
- optional Google keys injection
- FearlessKeys gated by INCLUDE_FEARLESS_KEYS