Skip to content

Conversation

rkharisov
Copy link

@rkharisov rkharisov commented Jun 21, 2021

Description of the Change

Iroha2 have similar with Fearless scheme with metadescription of API models consumed and sent by peer. We decided to separate common for both projects logic to allow reuse it for Iroha2 Android SDK

  • Moved common code to new gradle module 'scheme'
  • Removed 'RuntimeSnapshot' parameter from 'encode' and 'decode' methods of 'Type' due it specific for substrate blockchai. It causes late initiation of properties of 'RuntimeSnapshot'

Benefits

  • Reusing code

Possible Drawbacks

  • Harder to make changes without breaking code in one of the projects

@rkharisov rkharisov changed the title Feature/ir 996 Separated schema reading and codec models in module 'Schema' to make it reusable IR-996 Jun 21, 2021
@rkharisov rkharisov marked this pull request as ready for review June 21, 2021 06:11
@rkharisov rkharisov requested review from arvifox and valentunn June 21, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant