-
Notifications
You must be signed in to change notification settings - Fork 7
Expose version metadata #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Levi0804 Hi, thanks for opening the PR! I think it is too excessive to handle all versions of Iroha dependencies. All Iroha deps are of the same version anyway. What matters is:
So, the result would be just 2 env vars to pass from How does it sound? |
Happy to contribute!
We could also get this from
Sounds good to me! Do you think I should switch to using the vergen crate, or is this implementation okay? |
Yes.
No need to use the |
0x009922
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only a small naming change
Closes #77
This PR is a work in progress. Please let me know if the current approach looks good.
In the current approach I have created a
VERSION_METADATAenv variable (frombuild.rs) which holds a stringified JSON of our version metadata. This JSON string could then be deserialized appropriately and served at the correct endpoint.Current structure of JSON:
{ "versions": [ { "name": "iroha", "version": "2.0.0-rc.2.0" }, { "name": "iroha_explorer", "version": "0.2.1" }, { "name": "iroha_config", "version": "2.0.0-rc.2.0" }, { "name": "iroha_config_base", "version": "2.0.0-rc.2.0" } // ... ] }