Skip to content

Conversation

0x009922
Copy link
Contributor

@0x009922 0x009922 commented Mar 9, 2023

Changes

  • Migrate from Yarn & Lerna to PNPM
  • Use Storybook v7 (beta). It works with PNPM! But the stories should be re-written into Component Story Format 3.0. I only tested it on SAlert component so far.
  • Use TypeScript 5 (release candidate). It highlighted some new errors...
  • Tried to use much stricter TypeScript configuration, but we have 100+ errors with it! I left it for an upcoming PR.
  • Update ESLint rules. I had to disable some of them, and I think it should be fixed in an upcoming PR.
  • Remove Jest, use Vitest everywhere
  • Remove API Extractor. Use rollup-plugin-dts for .d.ts bundle
  • Set packages' type to module
  • Update a lot of packages
  • Use ^x.y in prod dependencies for better (?) deps resolution experience of library users
  • etc etc

This PR leaves a lot of TODOs and FIXMEs, and I think those should be fixed separately. Also I think it makes sense to release new versions with a pre-release tag, because there might be unexpected regressions.

To-Do

Issues to be resolved after the merge:


Fixes #423

@0x009922 0x009922 added the next Related to next lib iteration, i.e. based on Vue 3 label Mar 9, 2023
@Ctepan Ctepan self-requested a review March 9, 2023 07:54
@Ctepan
Copy link
Contributor

Ctepan commented Mar 9, 2023

There is yarn in docs. As far as I understand, it should be changed to pnpm commands

(exclude unnecessary files from the build)
@0x009922
Copy link
Contributor Author

Discussion notes: we decided to not merge it into next until StoryBook is ready.

@0x009922 0x009922 marked this pull request as draft March 20, 2023 04:09
@0x009922 0x009922 changed the title General project update Fresh breath Mar 27, 2023
@0x009922 0x009922 marked this pull request as ready for review May 2, 2023 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next Related to next lib iteration, i.e. based on Vue 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

d.ts rollup bug: not unwrapped @/types import Fix theme README
4 participants