Skip to content

Handle "Cancel" payment #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gramotei
Copy link

@gramotei gramotei commented Jun 3, 2020

Handle "Cancel" payment by resolving requestPayment promise with "undefined"

gramotei and others added 2 commits June 4, 2020 00:37
Handle "Cancel" payment by resolving requestPayment promise with "undefined"
Copy link
Owner

@sorokin0andrey sorokin0andrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gramotei Hi! Thank you for contributing! It's nice improvement :) I wrote a few comments. I think we will release it after fixes 👍

@sorokin0andrey
Copy link
Owner

sorokin0andrey commented Jun 24, 2020

@gramotei update requestPayment return type declaration in "index.d.ts" because it sends null value on dismiss. Also update examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants