Skip to content

Conversation

@giltho
Copy link
Contributor

@giltho giltho commented Apr 4, 2025

Todos:

  • Update dune-project to have pins
  • Update CI to actually use dune package management
  • Wait for it to actually work, currently blocked by dune#11606 but expecting more issues on the way
  • There is now a new issue while installing name_matcher_parser
  • Remove opam.template files
  • Adjust makefile and existing scripts

Name matcher issue ❌

File "dune.lock/name_matcher_parser.pkg", line 10, characters 3-79:
10 |    git+https://github.com/N1ark/charon#f47e331b9bc770852a9bcec7d51957f296ae4f1e)))
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Error trying to read targets after a rule was run:
- url/ac9e16babf03062c7f6bd17abd09657c/dir/doc-ml.html: Broken symbolic link
- url/ac9e16babf03062c7f6bd17abd09657c/dir/doc-rust.html: Broken symbolic link
Context: _private                              
File "runtime/dune", line 5, characters 13-19:
5 |   (libraries result)
                 ^^^^^^
Error: Library "result" not found.
-> required by library "visitors.runtime" in _build/default/runtime
-> required by _build/default/META.visitors
-> required by _build/install/default/lib/visitors/META
-> required by _build/default/visitors.install
-> required by alias install
File "src/dune", line 6, characters 48-64:
6 |   (libraries result compiler-libs.common ppxlib ppx_deriving.api)
                                                    ^^^^^^^^^^^^^^^^
Error: Library "ppx_deriving.api" not found.
-> required by library "visitors.ppx" in _build/default/src
-> required by _build/default/META.visitors
-> required by _build/install/default/lib/visitors/META
-> required by _build/default/visitors.install
-> required by alias install

@giltho giltho force-pushed the soteria/update-lsp branch from f4d7911 to 54f1192 Compare April 16, 2025 16:37
@N1ark
Copy link
Contributor

N1ark commented Apr 17, 2025

ah just saw the name matcher parser issue, will investigate when im back

@giltho
Copy link
Contributor Author

giltho commented Apr 17, 2025

Nah, don’t worry about that, we’re not moving to d’une package management anytime soon

@giltho
Copy link
Contributor Author

giltho commented Aug 20, 2025

New name-matcher-parser issue seems to be this:
ocaml/dune#9873

@giltho giltho force-pushed the soteria/update-lsp branch from 060c826 to 5002889 Compare August 20, 2025 15:38
@N1ark N1ark added cleanliness Quality of life improvements, to keep the codebase clean and healthy ci/cd Issues about CI/CD, for improving workflow or checking new PRs and commits. labels Nov 11, 2025
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
Signed-off-by: Sacha Ayoun <[email protected]>
@giltho giltho force-pushed the soteria/update-lsp branch from efacf03 to e871cb4 Compare December 15, 2025 16:42
Signed-off-by: Sacha Ayoun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Issues about CI/CD, for improving workflow or checking new PRs and commits. cleanliness Quality of life improvements, to keep the codebase clean and healthy

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants