Avoid unnecessary layout calculations #210
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N1ark
added
soteria-rust
N1ark
force-pushed
the
no-layout-magic
branch
from
cca8ac4 to
0fe5966
Compare
N1ark
force-pushed
the
no-layout-magic
branch
from
0fe5966 to
841a63d
Compare
giltho
approved these changes
Jan 11, 2026
Contributor
giltho
left a comment
giltho
left a comment
There was a problem hiding this comment.
I'm mostly just trusting this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #127
Depends on #205
Properly isolate layout computations (
compute_arbitrary_layout,compute_enum_layout) from layout translation from the frontend. The layout is now only computed if the frontend doesn't provide a layout; otherwise it is simply translated as-is. In particular, for the current version of Obol, only closures and tuples require manual calculation.Fix the implementation of
intrinsics::size_of_valandintrinsics::align_of_val, taking inspiration of the rustc implementation. The calculation should be a lot more accurate now, which is super important for e.g. thedropimplementation ofBox<dyn T>More reliably detect uninhabited types
I thought I wanted to do more here but I think this is already better than before and doing more would be over-engineering :) don't fix what isn't broken etc etc etc