Skip to content

WIP: Use only FoundationEssentials#628

Draft
t089 wants to merge 8 commits into
soto-project:mainfrom
t089:essentials
Draft

WIP: Use only FoundationEssentials#628
t089 wants to merge 8 commits into
soto-project:mainfrom
t089:essentials

Conversation

@t089

@t089 t089 commented Dec 12, 2024

Copy link
Copy Markdown

Copies over some bits and pieces from FoundationEssentials itself. Just wanted to make it build.

t089 added 4 commits December 10, 2024 15:20
# Conflicts:
#	Sources/SotoCore/Middleware/Middleware/S3Middleware.swift
#	Sources/SotoSignerV4/signer.swift
#	scripts/generate-errors.swift
#	scripts/generate-region-test.swift
#	scripts/generate-region.swift
@codecov

codecov Bot commented Dec 12, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 63.57616% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.71%. Comparing base (445ce27) to head (37a0b92).
⚠️ Report is 73 commits behind head on main.

Files with missing lines Patch % Lines
Sources/SotoUtils/String+Utils.swift 62.32% 55 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   80.54%   79.71%   -0.83%     
==========================================
  Files          78       79       +1     
  Lines        6575     6819     +244     
==========================================
+ Hits         5296     5436     +140     
- Misses       1279     1383     +104     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant