update session details with latest course information before switchin…

[C-likethis123]

…g courses

Description

Fixes the bug where switching courses redirects the user to the 'game' page, even when games are not enabled for the course.

The reason for this bug is because the loader function at src/pages/academy/academyRoutes checks for the enableGame flag in the Redux store before deciding whether to redirect, but the enableGame flag value belongs to the previous course and not the course it's about to switch to. The solution adopted in this MR is to update the latest viewed course to the course that the user is about to navigate to, before actually navigating to that course.

Screen.Recording.2025-01-31.at.12.30.06.AM.mov

Closes #3040.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Code quality improvements

How to test

1. Course configuration: create two courses - one with games enabled and one without games enabled.
2. Switch to the other course using the 'My courses' dropdown - it should redirect to the games page if the course has games enabled, and to the missions page otherwise.

Checklist

• I have tested this code
• I have updated the documentation

[coveralls]

Pull Request Test Coverage Report for Build 14180292581

Details

• 6 of 7 (85.71%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.02%) to 31.116%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/commons/dropdown/DropdownCourses.tsx	6	7	85.71%

Files with Coverage Reduction	New Missed Lines	%
src/commons/dropdown/DropdownCourses.tsx	1	61.11%

Totals
Change from base Build 14178090272:	0.02%
Covered Lines:	4893
Relevant Lines:	14832

---

💛 - Coveralls

[C-likethis123]

Hi @RichDom2185, can you review this again? Thank you!

[RichDom2185]

I don't think you can await a dispatch call? We should be handling the async logic via sagas instead.

What was the idea behind this change?

[C-likethis123]

Hi @RichDom2185, thank you for the feedback and sorry for the late reply.

I agree that the logic is odd - here's my reasoning behind the change:

1. when switching between courses, the router uses enableGame from the state of the current course to decide whether to route to the game page, or to route to another page.
2. this enableGame state is based on the current course, not the course that the user wants to navigate to.
3. the state is only updated via an API call after the routing logic kicks in and the user finishes navigation to a page.
4. the idea behind awaiting the dispatch call is to update the state of the latest viewed course to the course that I am trying to navigate to, before the routing logic kicks in

I can try to explore handling the async logic via sagas, but another suggestion from me is to enforce a navigation to a page that is common among all courses (eg the home page) so we don't have to use this conditional logic.