Skip to content

Remove Concurrent and Interpreter #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 10, 2025
Merged

Remove Concurrent and Interpreter #3130

merged 15 commits into from
Jun 10, 2025

Conversation

leeyi45
Copy link
Contributor

@leeyi45 leeyi45 commented Apr 24, 2025

Removal of the concurrent variant as well as the legacy interpreter.

I'm not sure if the functionality from manualToggleDebugger (including interrupt and paused) is still required within WorkspaceSaga. I have that commented out right now, but if anyone could comment on that that would be great.

@coveralls
Copy link

coveralls commented Apr 27, 2025

Pull Request Test Coverage Report for Build 14855284685

Details

  • 229 of 423 (54.14%) changed or added relevant lines in 24 files are covered.
  • 10 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 30.844%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/redux/utils.ts 12 14 85.71%
src/commons/workspace/WorkspaceActions.ts 1 3 33.33%
src/commons/sagas/SafeEffects.ts 8 11 72.73%
src/commons/repl/Repl.tsx 2 6 33.33%
src/commons/sagas/StoriesSaga.ts 1 6 16.67%
src/pages/playground/Playground.tsx 0 6 0.0%
src/commons/sagas/AchievementSaga.ts 1 8 12.5%
src/commons/sagas/LoginSaga.ts 1 8 12.5%
src/commons/workspace/WorkspaceReducer.ts 0 7 0.0%
src/commons/sagas/RemoteExecutionSaga.ts 1 10 10.0%
Files with Coverage Reduction New Missed Lines %
src/commons/sagas/WorkspaceSaga/index.ts 1 55.47%
src/commons/workspace/WorkspaceActions.ts 1 72.46%
src/commons/sagas/AchievementSaga.ts 3 0.68%
src/commons/sagas/SafeEffects.ts 5 48.94%
Totals Coverage Status
Change from base Build 14851045635: -0.2%
Covered Lines: 4844
Relevant Lines: 14816

💛 - Coveralls

@martin-henz martin-henz self-requested a review June 10, 2025 05:41
Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. More cleanup possible later, as discussed in telegram "SA 2526 Leadership Charm"

@martin-henz martin-henz merged commit a9c3041 into master Jun 10, 2025
9 checks passed
@martin-henz martin-henz deleted the remove-concurrent branch June 10, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants