-
Notifications
You must be signed in to change notification settings - Fork 194
Addition of the Skip Feature in the Source Academy Game #3732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
09318cc
Changed GameManager, GameActionManager, and GameMapTypes
ItsByt 14a1f30
Comments
ItsByt f45145b
Removed noSave
ItsByt 81dd27a
removed all noSave
ItsByt 3134b9a
changed
ItsByt 50e5257
test upload
ItsByt 213938c
Skip Button Features
ItsByt 929a420
Fixed some minor bugs
ItsByt a64003a
Fixed skip logic and changed peekNextLine
ItsByt 58bd51f
Merge branch 'master' into Personal
ItsByt 1340911
Re-added finishTypeWriting
ItsByt 567542c
Fix merge conflict when Merge branch 'Personal' of https://github.com…
ItsByt 9843347
Testin lint
ItsByt 4f6e333
Merge branch 'master' into Personal
ItsByt a977e08
change yarn
chenyuzhen2007-source 1d94b83
Fixed skipConfirm to Settings
ItsByt fb2e1e3
Merge branch 'Personal' of https://github.com/ItsByt/frontend into Pe…
ItsByt 7be35ec
Format Settings.ts
chenyuzhen2007-source e092ef5
Merge branch 'master' into Personal
martin-henz f1686b1
Merge branch 'master' into Personal
martin-henz 439c647
Merge branch 'master' into Personal
sayomaki 9fb07b1
revert changes to yarn.lock
sayomaki 8112de2
Change server port from 8080 to 8000
ItsByt e6a4fd3
Changed settings, constants and a bug fix for skip
ItsByt 8fd238b
Changed settings, constants and a bug fix for skip
ItsByt 7c6e38f
Changed settings, constants and a bug fix for skip
ItsByt 929cd4d
Merge branch 'master' into Personal
sayomaki 26ecbd2
Added 'Skip Confirm' option to settings header
ItsByt e1ba8cd
Add skip confirm radio buttons to settings layer
ItsByt b865ff2
Fixed skipRemainingDialogue
ItsByt 1e0790b
Merge branch 'master' into Personal
sayomaki 9181619
Merge branch 'master' into Personal
martin-henz 2461297
Merge branch 'master' into Personal
martin-henz ddfa7b4
Merge branch 'master' into Personal
sayomaki 5f32262
Use createButton instead of an additional function, and update asset …
sayomaki d7fa2d3
Remove skip icon from public assets
sayomaki 2092101
Merge branch 'master' into Personal
RichDom2185 6497ba4
Add back button display size
sayomaki 5755894
Make skip transition slower and more natural
sayomaki 94850ed
Fix skip button to not show for any upcoming line that requires user …
sayomaki 9b688a9
Improve skip transition to feel more natural
sayomaki e87c30b
Merge branch 'master' into Personal
RichDom2185 9c842a4
Merge branch 'master' of https://github.com/source-academy/frontend i…
RichDom2185 204f4b6
Reformat files post-merge
RichDom2185 4a34c8c
Improve comment formatting
RichDom2185 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be preferred to use the S3 for the skip icon instead, just like any other game asset. It should not be put into frontend.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, could someone help me move this asset into the S3? Thank you!