Remove tremor completely#3777
Conversation
Coverage Report for CI Build 24388012407Coverage remained the same at 40.892%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the application away from @tremor/react by replacing its UI components with BlueprintJS and internal Grading components across several modules, including Ground Control and Team Formation. The review feedback highlights that the Blueprint Button component should use the minimal boolean prop instead of a variant string. It also suggests using onMouseUp for actions that require immediate UI updates and recommends removing TODO comments in favor of formal task tracking.
| size="xs" | ||
| icon={() => <BpIcon icon={IconNames.MINUS} />} | ||
| variant="light" | ||
| variant="minimal" |
There was a problem hiding this comment.
The Blueprint Button component does not have a variant prop. To achieve the minimal style, use the minimal boolean prop instead.
| variant="minimal" | |
| minimal |
| onClick={handleIncrement} | ||
| /> | ||
| </Flex> | ||
| <Button variant="minimal" icon={IconNames.PLUS} onClick={handleIncrement} /> |
There was a problem hiding this comment.
The Blueprint Button component uses the minimal boolean prop instead of a variant prop. Additionally, use onMouseUp instead of onClick for button actions that require an immediate component redraw, as onClick may not trigger the redraw instantly.
| <Button variant="minimal" icon={IconNames.PLUS} onClick={handleIncrement} /> | |
| <Button minimal icon={IconNames.PLUS} onMouseUp={handleIncrement} /> |
References
- Use onMouseUp instead of onClick for button actions that require an immediate component redraw, as onClick may not trigger the redraw instantly.
| <GradingFlex> | ||
| <Tooltip placement={Position.TOP} content="Edit"> | ||
| <Link to={`/courses/${courseId}/teamformation/edit/${teamId}`}> | ||
| <Button intent="primary" icon={IconNames.EDIT} variant="minimal" /> |
There was a problem hiding this comment.
Blueprint's Button does not support a variant prop. Use the minimal prop instead.
| <Button intent="primary" icon={IconNames.EDIT} variant="minimal" /> | |
| <Button intent="primary" icon={IconNames.EDIT} minimal /> |
| <Button | ||
| intent="danger" | ||
| icon={IconNames.TRASH} | ||
| variant="minimal" |
There was a problem hiding this comment.
Blueprint's Button does not support a variant prop. Use the minimal prop instead.
| variant="minimal" | |
| minimal |
| size="xs" | ||
| icon={() => <BpIcon icon={IconNames.ARROW_LEFT} />} | ||
| variant="light" | ||
| variant="minimal" |
There was a problem hiding this comment.
Blueprint's Button uses the minimal prop rather than variant="minimal".
| variant="minimal" | |
| minimal |
| size="xs" | ||
| icon={() => <BpIcon icon={IconNames.ARROW_RIGHT} />} | ||
| variant="light" | ||
| variant="minimal" |
There was a problem hiding this comment.
Blueprint's Button uses the minimal prop rather than variant="minimal".
| variant="minimal" | |
| minimal |
|
|
||
| return ( | ||
| <button type="button" onClick={handleFilterChange} style={{ padding: 0 }}> | ||
| <Button variant="minimal" onClick={handleFilterChange} style={{ padding: 0 }}> |
There was a problem hiding this comment.
Blueprint's Button uses the minimal prop rather than variant="minimal". Also, use onMouseUp instead of onClick for button actions that require an immediate component redraw, as onClick may not trigger the redraw instantly.
| <Button variant="minimal" onClick={handleFilterChange} style={{ padding: 0 }}> | |
| <Button minimal onMouseUp={handleFilterChange} style={{ padding: 0 }}> |
References
- Use onMouseUp instead of onClick for button actions that require an immediate component redraw, as onClick may not trigger the redraw instantly.
|
|
||
| import { getBadgeColorFromLabelLegacy } from '../../grading/subcomponents/GradingBadges'; | ||
|
|
||
| // TODO: Remove after migration is completed |
There was a problem hiding this comment.
Avoid using TODO comments in the codebase. Please track this task in your project management system instead.
References
- Resolve known issues or track them in a formal task management system instead of leaving TODO comments in the codebase.
2 participants
Description
Replaces with BlueprintJS for UI consistency. Also because Tremor v1 isn't working following React 19 upgrade, so we have to remove it now.
Follow up to #3024. Closes #2849 (finally).
Type of change
How to test
Checklist