Robot minigame #340
Open
Robot minigame #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to robot-minigame
…to robot-minigame
…to robot-minigame
RichDom2185
requested changes
Jun 14, 2025
lhw-1
reviewed
Jun 27, 2025
There was a problem hiding this comment.
More of an overarching question - do you think it makes sense to frame it just as a maze minigame rather than a robot minigame? The idea of having it be a robot seems more context dependent within SA game, but as a module (which is published for not just Source Academy but for Source as a whole), it might be a nice idea to frame it as a general purpose maze minigame.
(Asking because this would necessitate some variable name changes)
lhw-1
reviewed
Jun 27, 2025
Comment on lines
+114
to
+116
| drawBorders(ctx, width, height); | ||
| drawAreas(ctx, areas); | ||
| drawRobot(ctx, robot); |
There was a problem hiding this comment.
Does it make sense to allow some optional parameters (e.g. colors, stroke style)?
| }; | ||
|
|
||
| // The speed to move at | ||
| const ANIMATION_SPEED : number = 2; |
There was a problem hiding this comment.
Might be nice to allow this to change as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the
robot-minigamemodule for use as a Source Academy Game minigame.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: